Skip to content

Edit student details endpointInitial #423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Edit student details endpointInitial #423

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
103c75a
Initial
magdalenajadach Aug 30, 2024
84c7cf9
reverse changes
magdalenajadach Sep 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
reverse changes
  • Loading branch information
@magdalenajadach
magdalenajadach committed Sep 5, 2024
commit 84c7cf9d576fb7631514b37d5660c88ace9afcf1
12 changes: 1 addition & 11 deletions app/controllers/api/school_students_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def update
)

if result.success?
update_student_details(@school)
head :no_content
else
render json: { error: result[:error] }, status: :unprocessable_entity
Expand Down Expand Up @@ -92,15 +91,6 @@ def create_owner_safeguarding_flag
email: current_user.email
)
end

def update_student_details(@school)
ProfileApiClient.update_school_student(
token: current_user.token,
school_id: school.id,
student_id: school_student.id,
name: school_student.name,
username: school_student.username
)
end

end
end