Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, now it can be compiled and run on dione after fixing some errors;
and I tried to eliminate the loop in
calculateHistogramsby mapping the one-dimensional thread ID onto two-dimensional indices. A common way (from good old google 🙏) to do this is to use division and modulus operations, here I didi = index / numDandj = index % numDmap the one-dimensional thread ID onto a two-dimensional pair (i, j).Let's say the
maxInputLengthis 4, then all the mapped indices are:And it seems to work.
Also, modify the printf with
outfilpointer using fprintf, so that the result is saved inomega.out.....but the results looks a little bit wierd though......haven't got idea about the wierd values in
omega.outat lines around 20.000, the omega values are so large around 1000, don't know it that make sense.