Tdb/book2 img updates #643
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hollasch
requested changes
Jun 22, 2020
|
Oops, neglected the second commit... |
hollasch
requested changes
Jun 22, 2020
There was a problem hiding this comment.
Again, tiny changes, excellent change.
On reflection, good call on explicitly including the header guards. The code won't work without them, so they definitely need to be included. We should make a full pass on all three books for this if you haven't already, but doesn't need to be in this change. I'll leave it up to you if you want to include it here or just create a standalone issue.
|
I tried to also explicitly add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of small changes in this one. Try to be thorough.