Skip to content

Fix SDK path issues with ubuntu-24.04 #409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ychescale9 merged 12 commits into from
Oct 11, 2024
Merged

Fix SDK path issues with ubuntu-24.04 #409

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
5e8cdd9
do not change default sdk path ownership
ychescale9 Oct 10, 2024
9c6dcc4
Test with 22.04 and 24.04
ychescale9 Oct 10, 2024
cf77116
Add test matrix for api-29;default;x86
ychescale9 Oct 10, 2024
56b52d2
Try to reproduce
ychescale9 Oct 10, 2024
71822f9
Swap matrix
ychescale9 Oct 10, 2024
7e1c968
Revert matrix.
ychescale9 Oct 10, 2024
7ff545c
update cmdline-tools path.
ychescale9 Oct 11, 2024
1984ae0
all with 24.04
ychescale9 Oct 11, 2024
4e2ec73
debug
ychescale9 Oct 11, 2024
e5f0ca8
Force new cmdline-tools installation
ychescale9 Oct 11, 2024
48163f3
create ${process.env.HOME}/.android/avd
ychescale9 Oct 11, 2024
63103da
leave 1 test with 22.04.
ychescale9 Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion lib/sdk-installer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ function installAndroidSdk(apiLevel, target, arch, channelId, emulatorBuild, ndk
const isOnMac = process.platform === 'darwin';
const isArm = process.arch === 'arm64';
const cmdlineToolsPath = `${process.env.ANDROID_HOME}/cmdline-tools`;
if (fs.existsSync(cmdlineToolsPath)) {
yield io.rmRF(cmdlineToolsPath);
}
Copy link
Contributor

@mikehardy mikehardy Oct 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may be a simpler / better approach than #411 - but with 411 there is the possibility we skip the install if the runner image ever has the updated version. That may have value

However I see this nice io.rmRF call and that's better than I do in 411 - I was shelling out to rm things

if (!fs.existsSync(cmdlineToolsPath)) {
console.log('Installing new cmdline-tools.');
const sdkUrl = isOnMac ? CMDLINE_TOOLS_URL_MAC : CMDLINE_TOOLS_URL_LINUX;
Expand All @@ -61,7 +64,7 @@ function installAndroidSdk(apiLevel, target, arch, channelId, emulatorBuild, ndk
yield io.mv(`${cmdlineToolsPath}/cmdline-tools`, `${cmdlineToolsPath}/latest`);
}
// add paths for commandline-tools and platform-tools
core.addPath(`${cmdlineToolsPath}/12.0:${cmdlineToolsPath}/12.0/bin:${process.env.ANDROID_HOME}/platform-tools`);
core.addPath(`${cmdlineToolsPath}/latest:${cmdlineToolsPath}/latest/bin:${process.env.ANDROID_HOME}/platform-tools`);
// set standard AVD path
core.exportVariable('ANDROID_AVD_HOME', `${process.env.HOME}/.android/avd`);
// accept all Android SDK licenses
Expand Down
7 changes: 4 additions & 3 deletions src/sdk-installer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ export async function installAndroidSdk(apiLevel: string, target: string, arch:
const isArm = process.arch === 'arm64';

const cmdlineToolsPath = `${process.env.ANDROID_HOME}/cmdline-tools`;

if (fs.existsSync(cmdlineToolsPath)) {
await io.rmRF(cmdlineToolsPath);
}
if (!fs.existsSync(cmdlineToolsPath)) {
console.log('Installing new cmdline-tools.');
const sdkUrl = isOnMac ? CMDLINE_TOOLS_URL_MAC : CMDLINE_TOOLS_URL_LINUX;
Expand All @@ -28,9 +32,6 @@ export async function installAndroidSdk(apiLevel: string, target: string, arch:
await io.mv(`${cmdlineToolsPath}/cmdline-tools`, `${cmdlineToolsPath}/latest`);
}

// print all folders under cmdline-tools
await exec.exec(`ls -l ${cmdlineToolsPath}`);

// add paths for commandline-tools and platform-tools
core.addPath(`${cmdlineToolsPath}/latest:${cmdlineToolsPath}/latest/bin:${process.env.ANDROID_HOME}/platform-tools`);

Expand Down