Android-centric package reorganization (#65) #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces new, Android centric packages including * rx.android.content for android.content related classes * rx.android.view for android.view related classes * rx.android.widget for android.widget related classes * rx.android.util for package agnostic classes Then it moves existing classes based on their Android counterparts. Although one of the goal is to reduce the number of publics, this change still does nothing but class move. More changes will follow.
|
Looks like we are on the right track! 👍 |
|
LGTM. Couple small things. |
This allows some contnet-related internal classes package local.
Some ViewObservable methods are for android.widget.* classes. This change moves these to newly introduced WidgetObservable. This turns some internal classes from public to package-local.
|
Thanks for the view Jake! The updated branch should address the feedback. |
There was a problem hiding this comment.
Should this be in an internal package? I don't think it's our responsibility to expose this in a public API.
There was a problem hiding this comment.
Makes sense. As there is only one internal class so far, I just renamed util to internal.
|
This looks great. Will merge on green. Thanks! |
JakeWharton
added a commit
that referenced
this pull request
Nov 21, 2014
Android-centric package reorganization (#65)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a first cut.
What seems good for me:
What doesn't look great but not sure how can be better:
WDYT? Comments are appreciated.