Skip to content

Conversation

hamidp
Copy link
Contributor

@hamidp hamidp commented Nov 25, 2014

Continuation of #85

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suuuuper nit: extra empty line!

@hamidp hamidp force-pushed the fixup-textview-actions branch from 35406da to 4299ccc Compare November 25, 2014 22:56
@hamidp
Copy link
Contributor Author

hamidp commented Nov 25, 2014

@JakeWharton Fixed! Thanks for catching it. I am super nitpicky about stuff like this.

I can't wait until we get checkstyle going.

@JakeWharton
Copy link
Contributor

I have preliminary checkstyle in #81 but blocked by other RxJava plugin nonsense. If I find the will (and time) I'll split it out so it can get in sooner.

JakeWharton added a commit that referenced this pull request Nov 25, 2014
Use ViewAction1 in ViewAction.setText and setTextResource.
@JakeWharton JakeWharton merged commit f9e02ef into ReactiveX:0.x Nov 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants