Add zip(iterable, selector) to RxScala

[zsxwing]

• Add zip(iterable, selector) to RxScala
• Use zip(iterable, selector) to reimplement zipWithIndex to resolve the issue mentioned in Fix bug in zipWithIndex and set zip(that, selector) public in RxScala #1226

/cc @samuelgruetter

[cloudbees-pull-request-builder]

RxJava-pull-requests #1147 SUCCESS
This pull request looks good

[samuelgruetter]

For zipping with an Observable, we have

def zip[U](that: Observable[U]): Observable[(T, U)]
def zipWith[U, R](that: Observable[U], selector: (T,U) => R): Observable[R]

So to be consistent, the signatures for zipping with an Iterable should be:

def zip[U](that: Iterable[U]): Observable[(T, U)]
def zipWith[U, R](that: Iterable[U], selector: (T,U) => R): Observable[R]

[samuelgruetter]

And you could add a good and bad example to RxScalaDemo: Bad zips an Observable.interval with an infinite Observable (and thus the same happens as with the previous zip version), and good zips Observable.interval with an infinite Iterable.

[headinthebox]

Agreed.

[benjchristensen]

I'll wait until a go ahead to merge this as it seems there are additions to make.

[zsxwing]

Already updated.

[cloudbees-pull-request-builder]

RxJava-pull-requests #1151 SUCCESS
This pull request looks good

[samuelgruetter]

We should wait with this until #1253 is fixed.

[benjchristensen]

Is this now ready to merge since #1253 is merged?

[headinthebox]

Yes, it delegates to the Java one.