Failing unit test for reduce, showing it does not implement backpressure correctly#1527
Merged
benjchristensen merged 2 commits intoReactiveX:masterfrom Jul 29, 2014
Conversation
Collaborator
|
RxJava-pull-requests #1447 FAILURE |
Contributor
Author
|
Just added another unit test. Interestingly, source.reduce(sum) fails, and source.reduce(0, sum) succeeds. |
|
RxJava-pull-requests #1448 FAILURE |
Member
|
Thanks for finding and fixing this. I complete missed |
Member
|
@mattrjacobs Can you touch this PR again to kick off builds and validate whether it is now fixed with #1529 merged? |
Contributor
Author
|
After takeLast implementaion was fixed, this unit test passes |
benjchristensen
added a commit
that referenced
this pull request
Jul 29, 2014
Failing unit test for reduce, showing it does not implement backpressure correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.