Skip to content

TakeWhile protect calls to predicate#220

Merged
benjchristensen merged 1 commit intoReactiveX:masterfrom
johngmyers:takewhile-predicate
Apr 1, 2013
Merged

TakeWhile protect calls to predicate#220
benjchristensen merged 1 commit intoReactiveX:masterfrom
johngmyers:takewhile-predicate

Conversation

@johngmyers
Copy link
Contributor

Per RX guideline 6.4, calls to selector functions passed in to the operator should be caught and fed through to the subscribed observer. Operator TakeWhile doesn't do this with the passed in predicate.

@cloudbees-pull-request-builder

RxJava-pull-requests #67 SUCCESS
This pull request looks good

benjchristensen added a commit that referenced this pull request Apr 1, 2013
TakeWhile protect calls to predicate
@benjchristensen benjchristensen merged commit 7a5c5bd into ReactiveX:master Apr 1, 2013
@benjchristensen
Copy link
Member

Thanks.

@johngmyers johngmyers deleted the takewhile-predicate branch April 1, 2013 17:28
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…_resilience4j

Add to companies who use resilience4j
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants