Changed Observable.empty() into a stateless constant observable.#2622
Merged
akarnokd merged 1 commit intoReactiveX:1.xfrom Feb 6, 2015
Merged
Changed Observable.empty() into a stateless constant observable.#2622akarnokd merged 1 commit intoReactiveX:1.xfrom
akarnokd merged 1 commit intoReactiveX:1.xfrom
Conversation
akarnokd
added a commit
that referenced
this pull request
Feb 6, 2015
Changed Observable.empty() into a stateless constant observable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Empty was always stateless so creating a new instance all the time (especially through a
from(Iterable)) is wasteful. Besides,onCompletedevents don't have to be backpressured.Should enable identity based optimizations discussed in #1653.