OperatorConcat - prevent request overflow and fix race condition#2951
Merged
akarnokd merged 1 commit intoReactiveX:1.xfrom May 15, 2015
Merged
OperatorConcat - prevent request overflow and fix race condition#2951akarnokd merged 1 commit intoReactiveX:1.xfrom
akarnokd merged 1 commit intoReactiveX:1.xfrom
Conversation
Member
|
Could you add your usual unit test for this? |
Collaborator
Author
|
Sure |
…d add n > 0 check to prevent race condition
davidmoten
force-pushed
the
concat-request-overflow
branch
from
63fde7d to
bad4d40
Compare
Collaborator
Author
|
Done, added unit test that failed on original codebase for request overflow. Didn't add a unit test for |
Member
|
Not necessary. |
Member
|
Thanks! |
akarnokd
added a commit
that referenced
this pull request
May 15, 2015
OperatorConcat - prevent request overflow and fix race condition
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used
BackpressureUtilsto prevent request overflow and added ann > 0check for requests to ensure thatsubscribeNextis not called concurrently (race condition).No unit tests written. Let me know if you think worth the effort.