A little Swing wrap-up#350
Merged
benjchristensen merged 5 commits intoReactiveX:masterfrom Sep 6, 2013
Merged
Conversation
added 5 commits
May 8, 2013 10:16
|
RxJava-pull-requests #241 SUCCESS |
Member
|
Looks good to me, and additive or cleanup, not breaking or changing anything as far as I can tell so this can be in a point release. |
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
A little Swing wrap-up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are some old changes in the Swing contrib library that wrap up a few loose endings (javadoc warnings, slightly inconsistent behavior for
KEY_TYPEDevents, an additional helper for computing relative mouse motion).I updated this to work with the current master (and fixed a few warnings concerning unused imports and double semicolons). I also checked whether this needs some variance generalizations, but it seems that it doesn't.