Merged
Conversation
- do not have 2 method overloads with similar method signatures, dynamic languages can not negotiate method dispatch using function arity - add doOnCompleted and doOnError methods instead of different doOnEach overloads
Member
Author
|
@nullstyle take note of this as you're planning on refactoring this code somewhat, also as an example of design we need to account for due to the polyglot nature of the library. |
|
RxJava-pull-requests #409 FAILURE |
benjchristensen
added a commit
that referenced
this pull request
Nov 13, 2013
See #483 for more info
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
rickbw
pushed a commit
to rickbw/RxJava
that referenced
this pull request
Jan 9, 2014
See ReactiveX#483 for more info
zsxwing
pushed a commit
to zsxwing/RxScala
that referenced
this pull request
Aug 19, 2014
See ReactiveX/RxJava#483 for more info
benjchristensen
added a commit
to ReactiveX/RxScala
that referenced
this pull request
Aug 19, 2014
See ReactiveX/RxJava#483 for more info
benjchristensen
added a commit
to ReactiveX/RxScala
that referenced
this pull request
Aug 19, 2014
See ReactiveX/RxJava#483 for more info
benjchristensen
added a commit
to ReactiveX/RxScala
that referenced
this pull request
Aug 19, 2014
See ReactiveX/RxJava#483 for more info
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very slight breaking change by deleting a method added in the last release. I did not catch this when I did the code review.