New contrib module: rxjava-async-util#704
Closed
akarnokd wants to merge 4 commits intoReactiveX:masterfrom
Closed
Conversation
Member
akarnokd
commented
Dec 28, 2013
akarnokd
commented
- Added startFuture, deferFuture, forEachFuture operators.
- Left out the CancellationToken resembling overloads as I was in doubt they can be meaningfully used. If a task is cancelled, it is enough to check the Thread.currentThread().isInterrupted() flag.
Home for async utility functions with juc.Future, Actions, Functions etc that don’t need to be in rxjava-core. As per discussions at: - ReactiveX#646 (comment) - ReactiveX#645 (comment) - ReactiveX#622 (comment)
|
RxJava-pull-requests #620 SUCCESS |
Member
|
Why is this changing 7700+ lines of |
Member
Author
|
I don't know. Maybe a line ending anomaly from your branch? Somehow these two classes got transformed into CRLF on checkout since I haven't touched them. I've changed them to LF. |
|
RxJava-pull-requests #622 SUCCESS |
Member
|
This pull request merged the master branch instead of rebasing so has lots of unnecessary and unrelated changes. I have created a new pull request after cherry picking just the relevant changes and avoiding the "merge with master" artifacts: #706 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.