Skip to content

Added overloaded createRequest method that takes an HttpContext instance#846

Merged
benjchristensen merged 1 commit intoReactiveX:masterfrom
johanhaleby:master
Feb 11, 2014
Merged

Added overloaded createRequest method that takes an HttpContext instance#846
benjchristensen merged 1 commit intoReactiveX:masterfrom
johanhaleby:master

Conversation

@johanhaleby
Copy link
Contributor

An HttpContext is needed when doing for example preemptive digest authentication with HTTP Client.

@cloudbees-pull-request-builder

RxJava-pull-requests #767 FAILURE
Looks like there's a problem with this pull request

@johanhaleby
Copy link
Contributor Author

I don't think I've caused the test failures since they failed even before I started working on the pull request.

@akarnokd
Copy link
Member

I have a fix for it in #777 but has been ignored so far.

@benjchristensen
Copy link
Member

Thank you for contributing!

benjchristensen added a commit that referenced this pull request Feb 11, 2014
Added overloaded createRequest method that takes an HttpContext instance
@benjchristensen benjchristensen merged commit 0d83c94 into ReactiveX:master Feb 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants