Skip to content

Added super(key) to _DatePickerComponent. #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2021
Merged

Added super(key) to _DatePickerComponent. #208

merged 1 commit into from
Jan 15, 2021

Conversation

awhitford
Copy link
Contributor

This addresses a flutter analyze issue:

info • A value for optional parameter 'key' isn't ever given • lib/flutter_datetime_picker.dart:225:12 • unused_element

Also removed some obsolete new keywords, and reformatted some code to decrease indentation depth and pass flutter format.

RicardoRB
RicardoRB approved these changes Dec 15, 2020
View reviewed changes
Copy link

@RicardoRB RicardoRB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code formatted, removed the word 'new' and added super(key: key). Nothing to add.

@awhitford
Copy link
Contributor Author

@RicardoRB Thanks for the feedback. Is @Realank the only one able to merge for this project?

@Realank Realank merged commit 586383c into Realank:master Jan 15, 2021
@awhitford awhitford deleted the super_key branch January 16, 2021 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@RicardoRB RicardoRB RicardoRB approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@awhitford @RicardoRB @Realank