Skip to content

Enable async modelset + refactor of model creation #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Enable async modelset + refactor of model creation #676

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0616eeb
Enable async modelset + refactor of model creation (draft)
alonre24 Apr 9, 2021
2df73fd
Fix in rdb loading
alonre24 Apr 10, 2021
6e613af
Free stats when releasing model type.
alonre24 Apr 11, 2021
989bd6e
Fix rdb decode v0 to fit the new changes.
alonre24 Apr 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Free stats when releasing model type.
  • Loading branch information
@alonre24
alonre24 committed Apr 11, 2021
commit 6e613af148c6ffc58b9a57b8257acb4d878243ce
2 changes: 2 additions & 0 deletions src/execution/background_modelset.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,8 @@ int RedisAI_ModelSet_Reply(RedisModuleCtx *ctx, RedisModuleString **argv, int ar
RAI_ModelGetShallowCopy(model_ctx->model);

RedisModule_ReplyWithSimpleString(ctx, "OK");

// todo: this should be replaced with RedisModule_Replicate (currently not replicating properly)
RedisModule_ReplicateVerbatim(ctx);
return REDISMODULE_OK;
}
Expand Down
4 changes: 3 additions & 1 deletion src/redis_ai_types/model_type.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ static void RAI_Model_AofRewrite(RedisModuleIO *aof, RedisModuleString *key, voi

static void RAI_Model_DTFree(void *value) {
RAI_Error err = {0};
RAI_ModelFree(value, &err);
RAI_Model *model = (RAI_Model *)value;
RAI_RemoveStatsEntry(model->infokey);
RAI_ModelFree(model, &err);
if (err.code != RAI_OK) {
printf("ERR: %s\n", err.detail);
RAI_ClearError(&err);
Expand Down