Skip to content

develop DLARF1F and implement in ORM2R, #1011 #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jun 19, 2024
Merged

develop DLARF1F and implement in ORM2R, #1011 #1019

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
b8a6443
develop DLARF1F and implement in ORM2R, #1011
EduardFedorenkov May 29, 2024
0d2bff7
fix DLARF1F in case lastv = 1, #1011
EduardFedorenkov May 30, 2024
a4698c3
align DLARF1F versions, #1011
EduardFedorenkov May 31, 2024
5e7dad3
remove dlarf1f prototype and add slarf1f, slarf1l, #1011
EduardFedorenkov Jun 3, 2024
8dd7e13
update single precision routines to use slarf1f and slarf1l, #1011
EduardFedorenkov Jun 4, 2024
6c0a98f
implement clarf1f, #1011
EduardFedorenkov Jun 5, 2024
5889e3e
try clarf1f in cunm2r, #1011
EduardFedorenkov Jun 5, 2024
1d4010e
fix lastv possible range in slarf1f and slarf1l, #1011
EduardFedorenkov Jun 6, 2024
ea943fc
fix lastv possible range in clarf1f, #1011
EduardFedorenkov Jun 6, 2024
b8b9771
implement clarf1l, #1011
EduardFedorenkov Jun 6, 2024
8ed1ab5
update single complex routines to use clarf1f and clarf1l, #1011
EduardFedorenkov Jun 7, 2024
b579759
small fix in larf1f and larf1l, #1011
EduardFedorenkov Jun 7, 2024
cbd638d
define larf1f and larf1l in lapack_64.h, #1011
EduardFedorenkov Jun 7, 2024
ba27bf0
small fix in routines to use larf1f and larf1l, #1011
EduardFedorenkov Jun 7, 2024
690067c
add firstv param in larf1l, #1011
EduardFedorenkov Jun 11, 2024
c8b1a51
code style small fixes, #1011
EduardFedorenkov Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
code style small fixes, #1011
  • Loading branch information
@EduardFedorenkov
EduardFedorenkov committed Jun 13, 2024
commit c8b1a514cd0e749ce5a0ad9836b65f23519b2f88
3 changes: 1 addition & 2 deletions SRC/cgelq2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,8 +180,7 @@ SUBROUTINE CGELQ2( M, N, A, LDA, TAU, WORK, INFO )
* Apply H(i) to A(i+1:m,i:n) from the right
*
CALL CLARF1F( 'Right', M-I, N-I+1, A( I, I ), LDA,
$ TAU( I ),
$ A( I+1, I ), LDA, WORK )
$ TAU( I ), A( I+1, I ), LDA, WORK )
END IF
CALL CLACGV( N-I+1, A( I, I ), LDA )
10 CONTINUE
Expand Down
6 changes: 3 additions & 3 deletions SRC/clarf1f.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
*
*> \htmlonly
*> Download CLARF1F + dependencies
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/clarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/clarf1f.f">
*> [TGZ]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/clarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/clarf1f.f">
*> [ZIP]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/clarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/clarf1f.f">
*> [TXT]</a>
*> \endhtmlonly
*
Expand Down
6 changes: 3 additions & 3 deletions SRC/clarf1l.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
*
*> \htmlonly
*> Download CLARF1L + dependencies
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/clarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/clarf1l.f">
*> [TGZ]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/clarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/clarf1l.f">
*> [ZIP]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/clarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/clarf1l.f">
*> [TXT]</a>
*> \endhtmlonly
*
Expand Down
18 changes: 6 additions & 12 deletions SRC/cunbdb.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,16 +485,13 @@ SUBROUTINE CUNBDB( TRANS, SIGNS, M, P, Q, X11, LDX11, X12,
*
IF( I .LT. Q ) THEN
CALL CLARF1F( 'R', P-I, Q-I, X11(I,I+1), LDX11,
$ TAUQ1(I),
$ X11(I+1,I+1), LDX11, WORK )
$ TAUQ1(I), X11(I+1,I+1), LDX11, WORK )
CALL CLARF1F( 'R', M-P-I, Q-I, X11(I,I+1), LDX11,
$ TAUQ1(I),
$ X21(I+1,I+1), LDX21, WORK )
$ TAUQ1(I), X21(I+1,I+1), LDX21, WORK )
END IF
IF ( P .GT. I ) THEN
CALL CLARF1F( 'R', P-I, M-Q-I+1, X12(I,I), LDX12,
$ TAUQ2(I),
$ X12(I+1,I), LDX12, WORK )
$ TAUQ2(I), X12(I+1,I), LDX12, WORK )
END IF
IF ( M-P .GT. I ) THEN
CALL CLARF1F( 'R', M-P-I, M-Q-I+1, X12(I,I), LDX12,
Expand Down Expand Up @@ -524,8 +521,7 @@ SUBROUTINE CUNBDB( TRANS, SIGNS, M, P, Q, X11, LDX11, X12,
*
IF ( P .GT. I ) THEN
CALL CLARF1F( 'R', P-I, M-Q-I+1, X12(I,I), LDX12,
$ TAUQ2(I),
$ X12(I+1,I), LDX12, WORK )
$ TAUQ2(I), X12(I+1,I), LDX12, WORK )
END IF
IF( M-P-Q .GE. 1 )
$ CALL CLARF1F( 'R', M-P-Q, M-Q-I+1, X12(I,I), LDX12,
Expand Down Expand Up @@ -596,8 +592,7 @@ SUBROUTINE CUNBDB( TRANS, SIGNS, M, P, Q, X11, LDX11, X12,
CALL CLARF1F( 'R', Q-I, P-I+1, X11(I,I), LDX11, TAUP1(I),
$ X11(I+1,I), LDX11, WORK )
CALL CLARF1F( 'R', M-Q-I+1, P-I+1, X11(I,I), LDX11,
$ TAUP1(I),
$ X12(I,I), LDX12, WORK )
$ TAUP1(I), X12(I,I), LDX12, WORK )
CALL CLARF1F( 'R', Q-I, M-P-I+1, X21(I,I), LDX21,
$ TAUP2(I), X21(I+1,I), LDX21, WORK )
CALL CLARF1F( 'R', M-Q-I+1, M-P-I+1, X21(I,I), LDX21,
Expand Down Expand Up @@ -638,8 +633,7 @@ SUBROUTINE CUNBDB( TRANS, SIGNS, M, P, Q, X11, LDX11, X12,
$ WORK )
END IF
CALL CLARF1F( 'L', M-Q-I+1, P-I, X12(I,I), 1,
$ CONJG(TAUQ2(I)),
$ X12(I,I+1), LDX12, WORK )
$ CONJG(TAUQ2(I)), X12(I,I+1), LDX12, WORK )

IF ( M-P .GT. I ) THEN
CALL CLARF1F( 'L', M-Q-I+1, M-P-I, X12(I,I), 1,
Expand Down
4 changes: 2 additions & 2 deletions SRC/cunbdb2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,8 +309,8 @@ SUBROUTINE CUNBDB2( M, P, Q, X11, LDX11, X21, LDX21, THETA,
C = COS( PHI(I) )
S = SIN( PHI(I) )
CALL CLARF1F( 'L', P-I, Q-I, X11(I+1,I), 1,
$ CONJG(TAUP1(I)),
$ X11(I+1,I+1), LDX11, WORK(ILARF) )
$ CONJG(TAUP1(I)), X11(I+1,I+1), LDX11,
$ WORK(ILARF) )
END IF
CALL CLARF1F( 'L', M-P-I+1, Q-I, X21(I,I), 1,
$ CONJG(TAUP2(I)), X21(I,I+1), LDX21,
Expand Down
4 changes: 2 additions & 2 deletions SRC/cunbdb3.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,8 @@ SUBROUTINE CUNBDB3( M, P, Q, X11, LDX11, X21, LDX21, THETA,
C = COS( PHI(I) )
S = SIN( PHI(I) )
CALL CLARF1F( 'L', M-P-I, Q-I, X21(I+1,I), 1,
$ CONJG(TAUP2(I)),
$ X21(I+1,I+1), LDX21, WORK(ILARF) )
$ CONJG(TAUP2(I)), X21(I+1,I+1), LDX21,
$ WORK(ILARF) )
END IF
CALL CLARF1F( 'L', P-I+1, Q-I, X11(I,I), 1, CONJG(TAUP1(I)),
$ X11(I,I+1), LDX11, WORK(ILARF) )
Expand Down
10 changes: 4 additions & 6 deletions SRC/cunbdb4.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,11 +310,9 @@ SUBROUTINE CUNBDB4( M, P, Q, X11, LDX11, X21, LDX21, THETA,
C = COS( THETA(I) )
S = SIN( THETA(I) )
CALL CLARF1F( 'L', P, Q, PHANTOM(1), 1, CONJG(TAUP1(1)),
$ X11,
$ LDX11, WORK(ILARF) )
$ X11, LDX11, WORK(ILARF) )
CALL CLARF1F( 'L', M-P, Q, PHANTOM(P+1), 1,
$ CONJG(TAUP2(1)),
$ X21, LDX21, WORK(ILARF) )
$ CONJG(TAUP2(1)), X21, LDX21, WORK(ILARF) )
ELSE
CALL CUNBDB5( P-I+1, M-P-I+1, Q-I+1, X11(I,I-1), 1,
$ X21(I,I-1), 1, X11(I,I), LDX11, X21(I,I),
Expand Down Expand Up @@ -372,8 +370,8 @@ SUBROUTINE CUNBDB4( M, P, Q, X11, LDX11, X21, LDX21, THETA,
$ LDX21,
$ TAUQ1(I) )
CALL CLARF1F( 'R', Q-I, Q-I+1, X21(M-Q+I-P,I), LDX21,
$ TAUQ1(I),
$ X21(M-Q+I-P+1,I), LDX21, WORK(ILARF) )
$ TAUQ1(I), X21(M-Q+I-P+1,I), LDX21,
$ WORK(ILARF) )
CALL CLACGV( Q-I+1, X21(M-Q+I-P,I), LDX21 )
END DO
*
Expand Down
3 changes: 1 addition & 2 deletions SRC/cung2l.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,8 +179,7 @@ SUBROUTINE CUNG2L( M, N, K, A, LDA, TAU, WORK, INFO )
*
A( M-N+II, II ) = ONE
CALL CLARF1L( 'Left', M-N+II, II-1, A( 1, II ), 1, TAU( I ),
$ A,
$ LDA, WORK )
$ A, LDA, WORK )
CALL CSCAL( M-N+II-1, -TAU( I ), A( 1, II ), 1 )
A( M-N+II, II ) = ONE - TAU( I )
*
Expand Down
3 changes: 1 addition & 2 deletions SRC/cunm2r.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,7 @@ SUBROUTINE CUNM2R( SIDE, TRANS, M, N, K, A, LDA, TAU, C, LDC,
TAUI = CONJG( TAU( I ) )
END IF
CALL CLARF1F( SIDE, MI, NI, A( I, I ), 1, TAUI, C( IC, JC ),
$ LDC,
$ WORK )
$ LDC, WORK )
10 CONTINUE
RETURN
*
Expand Down
6 changes: 2 additions & 4 deletions SRC/sgebd2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,8 +247,7 @@ SUBROUTINE SGEBD2( M, N, A, LDA, D, E, TAUQ, TAUP, WORK, INFO )
*
IF( I.LT.N )
$ CALL SLARF1F( 'Left', M-I+1, N-I, A( I, I ), 1,
$ TAUQ( I ),
$ A( I, I+1 ), LDA, WORK )
$ TAUQ( I ), A( I, I+1 ), LDA, WORK )
*
IF( I.LT.N ) THEN
*
Expand Down Expand Up @@ -299,8 +298,7 @@ SUBROUTINE SGEBD2( M, N, A, LDA, D, E, TAUQ, TAUP, WORK, INFO )
* Apply H(i) to A(i+1:m,i+1:n) from the left
*
CALL SLARF1F( 'Left', M-I, N-I, A( I+1, I ), 1,
$ TAUQ( I ),
$ A( I+1, I+1 ), LDA, WORK )
$ TAUQ( I ), A( I+1, I+1 ), LDA, WORK )
ELSE
TAUQ( I ) = ZERO
END IF
Expand Down
4 changes: 0 additions & 4 deletions SRC/sgehd2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,10 +160,6 @@ SUBROUTINE SGEHD2( N, ILO, IHI, A, LDA, TAU, WORK, INFO )
*
* =====================================================================
*
* .. Parameters ..
REAL ONE
PARAMETER ( ONE = 1.0E+0 )
* ..
* .. Local Scalars ..
INTEGER I
* ..
Expand Down
7 changes: 1 addition & 6 deletions SRC/sgelq2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,10 +140,6 @@ SUBROUTINE SGELQ2( M, N, A, LDA, TAU, WORK, INFO )
*
* =====================================================================
*
* .. Parameters ..
REAL ONE
PARAMETER ( ONE = 1.0E+0 )
* ..
* .. Local Scalars ..
INTEGER I, K
* ..
Expand Down Expand Up @@ -183,8 +179,7 @@ SUBROUTINE SGELQ2( M, N, A, LDA, TAU, WORK, INFO )
* Apply H(i) to A(i+1:m,i:n) from the right
*
CALL SLARF1F( 'Right', M-I, N-I+1, A( I, I ), LDA,
$ TAU( I ),
$ A( I+1, I ), LDA, WORK )
$ TAU( I ), A( I+1, I ), LDA, WORK )
END IF
10 CONTINUE
RETURN
Expand Down
7 changes: 1 addition & 6 deletions SRC/sgeql2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,6 @@ SUBROUTINE SGEQL2( M, N, A, LDA, TAU, WORK, INFO )
*
* =====================================================================
*
* .. Parameters ..
REAL ONE
PARAMETER ( ONE = 1.0E+0 )
* ..
* .. Local Scalars ..
INTEGER I, K
* ..
Expand Down Expand Up @@ -177,8 +173,7 @@ SUBROUTINE SGEQL2( M, N, A, LDA, TAU, WORK, INFO )
* Apply H(i) to A(1:m-k+i,1:n-k+i-1) from the left
*
CALL SLARF1L( 'Left', M-K+I, N-K+I-1, A( 1, N-K+I ), 1,
$ TAU( I ),
$ A, LDA, WORK )
$ TAU( I ), A, LDA, WORK )
10 CONTINUE
RETURN
*
Expand Down
4 changes: 0 additions & 4 deletions SRC/sgeqr2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,10 +141,6 @@ SUBROUTINE SGEQR2( M, N, A, LDA, TAU, WORK, INFO )
*
* =====================================================================
*
* .. Parameters ..
REAL ONE
PARAMETER ( ONE = 1.0E+0 )
* ..
* .. Local Scalars ..
INTEGER I, K
* ..
Expand Down
4 changes: 0 additions & 4 deletions SRC/sgeqr2p.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,10 +145,6 @@ SUBROUTINE SGEQR2P( M, N, A, LDA, TAU, WORK, INFO )
*
* =====================================================================
*
* .. Parameters ..
REAL ONE
PARAMETER ( ONE = 1.0E+0 )
* ..
* .. Local Scalars ..
INTEGER I, K
* ..
Expand Down
4 changes: 0 additions & 4 deletions SRC/sgerq2.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,10 +134,6 @@ SUBROUTINE SGERQ2( M, N, A, LDA, TAU, WORK, INFO )
*
* =====================================================================
*
* .. Parameters ..
REAL ONE
PARAMETER ( ONE = 1.0E+0 )
* ..
* .. Local Scalars ..
INTEGER I, K
* ..
Expand Down
6 changes: 3 additions & 3 deletions SRC/slarf1f.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,11 +8,11 @@
*
*> \htmlonly
*> Download SLARF1F + dependencies
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/slarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/slarf1f.f">
*> [TGZ]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/slarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/slarf1f.f">
*> [ZIP]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/slarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/slarf1f.f">
*> [TXT]</a>
*> \endhtmlonly
*
Expand Down
6 changes: 3 additions & 3 deletions SRC/slarf1l.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
*
*> \htmlonly
*> Download SLARF1L + dependencies
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/slarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.tgz?format=tgz&filename=/lapack/lapack_routine/slarf1l.f">
*> [TGZ]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/slarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.zip?format=zip&filename=/lapack/lapack_routine/slarf1l.f">
*> [ZIP]</a>
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/slarf.f">
*> <a href="http://www.netlib.org/cgi-bin/netlibfiles.txt?format=txt&filename=/lapack/lapack_routine/slarf1l.f">
*> [TXT]</a>
*> \endhtmlonly
*
Expand Down
7 changes: 1 addition & 6 deletions SRC/sopmtr.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,6 @@ SUBROUTINE SOPMTR( SIDE, UPLO, TRANS, M, N, AP, TAU, C, LDC,
*
* =====================================================================
*
* .. Parameters ..
REAL ONE
PARAMETER ( ONE = 1.0E+0 )
* ..
* .. Local Scalars ..
LOGICAL FORWRD, LEFT, NOTRAN, UPPER
INTEGER I, I1, I2, I3, IC, II, JC, MI, NI, NQ
Expand Down Expand Up @@ -261,8 +257,7 @@ SUBROUTINE SOPMTR( SIDE, UPLO, TRANS, M, N, AP, TAU, C, LDC,
* Apply H(i)
*
CALL SLARF1L( SIDE, MI, NI, AP( II-I+1 ), 1, TAU( I ), C,
$ LDC,
$ WORK )
$ LDC, WORK )
*
IF( FORWRD ) THEN
II = II + I + 2
Expand Down
Loading