Skip to content

2-by-1 CS decomposition fixes #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 17, 2021
Merged

2-by-1 CS decomposition fixes #405

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb1921a
xUNCSD2BY1: improve LRWORK handling
christoph-conrads Apr 15, 2020
fe3cdc4
xORCSD2BY1, xUNCSD2BY1: fix U2 orthogonality
christoph-conrads Apr 21, 2020
0c32d4b
xUNCSD2BY1: allow workspace query with LRWORK=-1
christoph-conrads Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
xUNCSD2BY1: improve LRWORK handling 
* check LRWORK
* pass actual LRWORK value to xBBCSD
  • Loading branch information
@christoph-conrads
christoph-conrads committed Feb 14, 2021
commit eb1921af6e33a1ba09604d3562ba001b32e80fba
7 changes: 5 additions & 2 deletions SRC/cuncsd2by1.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,6 +513,9 @@ SUBROUTINE CUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
IF( LWORK .LT. LWORKMIN .AND. .NOT.LQUERY ) THEN
INFO = -19
END IF
IF( LRWORK .LT. LRWORKMIN .AND. .NOT.LQUERY ) THEN
INFO = -21
END IF
END IF
IF( INFO .NE. 0 ) THEN
CALL XERBLA( 'CUNCSD2BY1', -INFO )
Expand Down Expand Up @@ -566,8 +569,8 @@ SUBROUTINE CUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ RWORK(IPHI), U1, LDU1, U2, LDU2, V1T, LDV1T, CDUM,
$ 1, RWORK(IB11D), RWORK(IB11E), RWORK(IB12D),
$ RWORK(IB12E), RWORK(IB21D), RWORK(IB21E),
$ RWORK(IB22D), RWORK(IB22E), RWORK(IBBCSD), LBBCSD,
$ CHILDINFO )
$ RWORK(IB22D), RWORK(IB22E), RWORK(IBBCSD),
$ LRWORK-IBBCSD+1, CHILDINFO )
*
* Permute rows and columns to place zero submatrices in
* preferred positions
Expand Down
7 changes: 5 additions & 2 deletions SRC/zuncsd2by1.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,6 +511,9 @@ SUBROUTINE ZUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
IF( LWORK .LT. LWORKMIN .AND. .NOT.LQUERY ) THEN
INFO = -19
END IF
IF( LRWORK .LT. LRWORKMIN .AND. .NOT.LQUERY ) THEN
INFO = -21
END IF
END IF
IF( INFO .NE. 0 ) THEN
CALL XERBLA( 'ZUNCSD2BY1', -INFO )
Expand Down Expand Up @@ -564,8 +567,8 @@ SUBROUTINE ZUNCSD2BY1( JOBU1, JOBU2, JOBV1T, M, P, Q, X11, LDX11,
$ RWORK(IPHI), U1, LDU1, U2, LDU2, V1T, LDV1T, CDUM,
$ 1, RWORK(IB11D), RWORK(IB11E), RWORK(IB12D),
$ RWORK(IB12E), RWORK(IB21D), RWORK(IB21E),
$ RWORK(IB22D), RWORK(IB22E), RWORK(IBBCSD), LBBCSD,
$ CHILDINFO )
$ RWORK(IB22D), RWORK(IB22E), RWORK(IBBCSD),
$ LRWORK-IBBCSD+1, CHILDINFO )
*
* Permute rows and columns to place zero submatrices in
* preferred positions
Expand Down