Skip to content

Fix error on LAPACKE_*tpmqrt_work for ROW MAJOR matrices #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 18, 2022
Merged

Fix error on LAPACKE_*tpmqrt_work for ROW MAJOR matrices #540

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1c33cda
Fix double routine LAPACKE_dtpmqrt_work
weslleyspereira Apr 22, 2021
64a0db9
Applies fixes thanks to @angsch
weslleyspereira Oct 10, 2022
c9e0121
Apply the fixes on lapacke_(c,s,z)tpmqrt_work.c
weslleyspereira Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Applies fixes thanks to @angsch
  • Loading branch information
@weslleyspereira
weslleyspereira committed Oct 10, 2022
commit 64a0db9b190a685807574a7eb912156263840cb7
8 changes: 4 additions & 4 deletions LAPACKE/src/lapacke_dtpmqrt_work.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,8 +49,8 @@ lapack_int LAPACKE_dtpmqrt_work( int matrix_layout, char side, char trans,
}
} else if( matrix_layout == LAPACK_ROW_MAJOR ) {
lapack_int nrowsA, ncolsA, nrowsV;
if ( side == 'L' ) { nrowsA = k; ncolsA = n; nrowsV = m; }
else if ( side == 'R' ) { nrowsA = m; ncolsA = k; nrowsV = n; }
if ( side == LAPACKE_lsame(side, 'l') ) { nrowsA = k; ncolsA = n; nrowsV = m; }
else if ( side == LAPACKE_lsame(side, 'r') ) { nrowsA = m; ncolsA = k; nrowsV = n; }
else {
info = -2;
LAPACKE_xerbla( "LAPACKE_dtpmqrt_work", info );
Expand Down Expand Up @@ -118,8 +118,8 @@ lapack_int LAPACKE_dtpmqrt_work( int matrix_layout, char side, char trans,
info = info - 1;
}
/* Transpose output matrices */
LAPACKE_dge_trans( LAPACK_COL_MAJOR, ncolsA, nrowsA, a_t, lda_t, a, lda );
LAPACKE_dge_trans( LAPACK_COL_MAJOR, n, m, b_t, ldb_t, b, ldb );
LAPACKE_dge_trans( LAPACK_COL_MAJOR, nrowsA, ncolsA, a_t, lda_t, a, lda );
LAPACKE_dge_trans( LAPACK_COL_MAJOR, m, n, b_t, ldb_t, b, ldb );
/* Release memory and exit */
LAPACKE_free( b_t );
exit_level_3:
Expand Down