Skip to content

Adding Dynamic Mode Decomposition (DMD) into LAPACK #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jun 5, 2023
Merged

Adding Dynamic Mode Decomposition (DMD) into LAPACK #736

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
cea00a7
Adding DMD algorithm in four precisions, tester will follow
Oct 18, 2022
dc9b4e8
Updating precision routines and beginning integration of tester
Oct 19, 2022
a8e4012
Adding the DMDQ codes
Oct 22, 2022
7aeab07
Fix for complex dmdq codes and progress to tester
Nov 2, 2022
fd272e7
Progress to the testing implementation in double precision
Nov 9, 2022
c4adf64
Removing unused variables
Nov 15, 2022
7bfb8ff
single precision tester finished, working on double complex
Nov 17, 2022
21059dc
Progressing code
Dec 6, 2022
c65a7a7
Progress to resolving the bug with complex testers
Feb 9, 2023
3b08c51
Updating src files, testing all precisions. Some clean-up remains but…
Mar 16, 2023
bd1204d
Merge branch 'Reference-LAPACK:master' into master
dbielich Mar 21, 2023
25030ae
Improving testers - will need to investigate float precision impl
Mar 21, 2023
c91783e
Merge branch 'master' of https://github.com/dbielich/lapack88
Mar 21, 2023
1e2d26e
adding correction to schkdmd tester
Mar 21, 2023
e52daa3
Fixing compilation warning error for git
Mar 21, 2023
fbd853c
Adding lapacke wrappers for dmd routines - dmdq is needed yet
Mar 24, 2023
cc50227
Adding first precision of dmdq impl for lapacke
Mar 24, 2023
f74a632
Finishing up first impl of lapacke wrappers, waiting for review to re…
Mar 24, 2023
b5f984f
Fixing lapacke wrappers for memory leak conventions
Mar 27, 2023
7e42285
Addressing lapacke incorrectness and comments to the PR in general
Apr 18, 2023
e798ab2
Fixing interger workspace allocation
Apr 18, 2023
c6c2689
Fixes for the integer workspace
May 7, 2023
59f4d58
Documentation fix
May 7, 2023
8ade5d1
Pushing final comments on PR for current progress
dbielich Jun 1, 2023
fd82c87
Merge branch 'master' into master
langou Jun 1, 2023
561e5bd
Requested changes for typos and convention errors in branch
dbielich Jun 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Progress to resolving the bug with complex testers
  • Loading branch information
Daniel Bielich committed Feb 9, 2023
commit c65a7a77d4c47b0e22864f5e3dfc50dc4fe7232d
7 changes: 5 additions & 2 deletions SRC/zgedmdq.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ SUBROUTINE ZGEDMDQ( JOBS, JOBZ, JOBR, JOBQ, JOBT, JOBF, &
!.....
! USE PRECISION, ONLY: WP => DP ! double precision
! IMPLICIT NONE
use iso_fortran_env, only: real32
use iso_fortran_env, only: real64
IMPLICIT NONE
integer, parameter :: WP = real32
integer, parameter :: WP = real64

!.....
! Scalar arguments
Expand Down Expand Up @@ -616,6 +616,8 @@ SUBROUTINE ZGEDMDQ( JOBS, JOBZ, JOBR, JOBQ, JOBT, JOBF, &
ZWORK(1) = MLWORK
ZWORK(2) = OLWORK
WORK(1) = MLRWRK
!WRITE(*,*) 'ZWORK(1) = ', ZWORK(1)
!WRITE(*,*) 'ZWORK(2) = ', ZWORK(2)
RETURN
END IF
!.....
Expand Down Expand Up @@ -645,6 +647,7 @@ SUBROUTINE ZGEDMDQ( JOBS, JOBZ, JOBR, JOBQ, JOBT, JOBF, &
EIGS, Z, LDZ, RES, B, LDB, V, LDV, &
S, LDS, ZWORK(MINMN+1), LZWORK-MINMN, &
WORK, LWORK, IWORK, LIWORK, INFO1 )
!S, LDS, ZWORK(MINMN+1), LZWORK-MINMN, &
IF ( INFO1 == 2 .OR. INFO1 == 3 ) THEN
! Return with error code. See ZGEDMD for details.
INFO = INFO1
Expand Down
10 changes: 9 additions & 1 deletion TESTING/EIG/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ CEIGTST = cchkee.o \
csgt01.o cslect.o csyl01.o\
cstt21.o cstt22.o cunt01.o cunt03.o

CDMDEIGTST = cchkdmd.o

DZIGTST = dlafts.o dlahd2.o dlasum.o dlatb9.o dstech.o dstect.o \
dsvdch.o dsvdct.o dsxt1.o

Expand Down Expand Up @@ -129,13 +131,16 @@ all: single complex double complex16

.PHONY: single complex double complex16
single: xeigtsts xdmdeigtsts
complex: xeigtstc
complex: xeigtstc xdmdeigtstc
double: xeigtstd xdmdeigtstd
complex16: xeigtstz xdmdeigtstz

xdmdeigtsts: $(SDMDEIGTST) $(TMGLIB) $(LAPACKLIB) $(BLASLIB)
$(FC) $(FFLAGS) $(LDFLAGS) -o $@ $^

xdmdeigtstc: $(CDMDEIGTST) $(TMGLIB) $(LAPACKLIB) $(BLASLIB)
$(FC) $(FFLAGS) $(LDFLAGS) -o $@ $^

xdmdeigtstd: $(DDMDEIGTST) $(TMGLIB) $(LAPACKLIB) $(BLASLIB)
$(FC) $(FFLAGS) $(LDFLAGS) -o $@ $^

Expand All @@ -155,6 +160,7 @@ xeigtstz: $(ZEIGTST) $(DZIGTST) $(AEIGTST) $(TMGLIB) $(LAPACKLIB) $(BLASLIB)
$(FC) $(FFLAGS) $(LDFLAGS) -o $@ $^

$(SDMDEIGTST): $(FRC)
$(CDMDEIGTST): $(FRC)
$(DDMDEIGTST): $(FRC)
$(ZDMDEIGTST): $(FRC)
$(AEIGTST): $(FRC)
Expand Down Expand Up @@ -185,6 +191,8 @@ zchkee.o: zchkee.F
$(FC) $(FFLAGS_DRV) -c -o $@ $<
schkdmd.o: schkdmd.f90
$(FC) $(FFLAGS_DRV) -c -o $@ $<
cchkdmd.o: cchkdmd.f90
$(FC) $(FFLAGS_DRV) -c -o $@ $<
dchkdmd.o: dchkdmd.f90
$(FC) $(FFLAGS_DRV) -c -o $@ $<
zchkdmd.o: zchkdmd.f90
Expand Down
Loading