Improve variants of Cholesky and QR #847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sceil.f is only referenced in SRC/VARIANTS/qr/LL/. Replace all occurrences of calls to sceil with the Fortran intrinsics CEILING, which is already used by a bunch of other routines.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #847 +/- ##
=======================================
Coverage 0.00% 0.00%
=======================================
Files 1908 1908
Lines 186954 186954
=======================================
Misses 186954 186954 ☔ View full report in Codecov by Sentry. |
Contributor
|
Oh my. Thanks @angsch. I am thankful we are removing the SRC/VARIANTS/qr/LL/sceil.f file. Good idea. |
langou
approved these changes
Jun 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sceil.f, which provides the same functionality as the Fortran intrinsicCEILING.sceilwas only used in the LL variant of QR. All occurrences have been replaced with calls toCEILING, which is already used by routines inSRC.