Skip to content

Fixed usage of uninitialized variables in TESTING #961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Fixed usage of uninitialized variables in TESTING #961

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4a26507
Initialize test results to zero in LIN testing routines to preempt po…
ACSimon33 Dec 15, 2023
f6355dc
Updated array index calculations in cchkqp3rk.f, dchkqp3rk.f,
ACSimon33 Dec 15, 2023
4bd18e2
Refactor test result initialization and reporting
ACSimon33 Dec 18, 2023
7113caa
Fixed commented out result initialization
ACSimon33 Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Initialize test results to zero in LIN testing routines to preempt po… 
…tential garbage data

influencing the test evaluations.
  • Loading branch information
@ACSimon33
ACSimon33 committed Dec 15, 2023
commit 4a26507b5ff7526e4bcb8f5f3d9c2555e6091629
3 changes: 3 additions & 0 deletions TESTING/LIN/cchkqp3rk.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,9 @@ SUBROUTINE CCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
CALL XLAENV( 1, NB )
NX = NXVAL( INB )
CALL XLAENV( 3, NX )
DO I = 1, NTESTS
RESULT( I ) = ZERO
END DO
*
* We do MIN(M,N)+1 because we need a test for KMAX > N,
* when KMAX is larger than MIN(M,N), KMAX should be
Expand Down
3 changes: 3 additions & 0 deletions TESTING/LIN/dchkqp3rk.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,6 +584,9 @@ SUBROUTINE DCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
CALL XLAENV( 1, NB )
NX = NXVAL( INB )
CALL XLAENV( 3, NX )
DO I = 1, NTESTS
RESULT( I ) = ZERO
END DO
*
* We do MIN(M,N)+1 because we need a test for KMAX > N,
* when KMAX is larger than MIN(M,N), KMAX should be
Expand Down
3 changes: 3 additions & 0 deletions TESTING/LIN/schkqp3rk.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -583,6 +583,9 @@ SUBROUTINE SCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
CALL XLAENV( 1, NB )
NX = NXVAL( INB )
CALL XLAENV( 3, NX )
DO I = 1, NTESTS
RESULT( I ) = ZERO
END DO
*
* We do MIN(M,N)+1 because we need a test for KMAX > N,
* when KMAX is larger than MIN(M,N), KMAX should be
Expand Down
3 changes: 3 additions & 0 deletions TESTING/LIN/zchkqp3rk.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,6 +587,9 @@ SUBROUTINE ZCHKQP3RK( DOTYPE, NM, MVAL, NN, NVAL, NNS, NSVAL,
CALL XLAENV( 1, NB )
NX = NXVAL( INB )
CALL XLAENV( 3, NX )
DO I = 1, NTESTS
RESULT( I ) = ZERO
END DO
*
* We do MIN(M,N)+1 because we need a test for KMAX > N,
* when KMAX is larger than MIN(M,N), KMAX should be
Expand Down