Skip to content

Two small fixes of bdsqr #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Two small fixes of bdsqr #989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
acbac10
Update documentation of work size in bdsqr (thanks @TarcioV)
angsch Dec 16, 2023
230b8c4
Fix -ZERO singular value in bdsqr
angsch Dec 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion SRC/cbdsqr.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
*>
*> \param[out] RWORK
*> \verbatim
*> RWORK is REAL array, dimension (4*N)
*> RWORK is REAL array, dimension (4*(N-1))
*> \endverbatim
*>
*> \param[out] INFO
Expand Down Expand Up @@ -809,6 +809,12 @@ SUBROUTINE CBDSQR( UPLO, N, NCVT, NRU, NCC, D, E, VT, LDVT, U,
*
160 CONTINUE
DO 170 I = 1, N
IF( D( I ).EQ.ZERO ) THEN
*
* Avoid -ZERO
*
D( I ) = ZERO
END IF
IF( D( I ).LT.ZERO ) THEN
D( I ) = -D( I )
*
Expand Down
6 changes: 6 additions & 0 deletions SRC/dbdsqr.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -817,6 +817,12 @@ SUBROUTINE DBDSQR( UPLO, N, NCVT, NRU, NCC, D, E, VT, LDVT, U,
*
160 CONTINUE
DO 170 I = 1, N
IF( D( I ).EQ.ZERO ) THEN
*
* Avoid -ZERO
*
D( I ) = ZERO
END IF
IF( D( I ).LT.ZERO ) THEN
D( I ) = -D( I )
*
Expand Down
9 changes: 8 additions & 1 deletion SRC/sbdsqr.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
*>
*> \param[out] WORK
*> \verbatim
*> WORK is REAL array, dimension (4*N)
*> WORK is REAL array, dimension (4*(N-1))
*> \endverbatim
*>
*> \param[out] INFO
Expand Down Expand Up @@ -817,7 +817,14 @@ SUBROUTINE SBDSQR( UPLO, N, NCVT, NRU, NCC, D, E, VT, LDVT, U,
*
160 CONTINUE
DO 170 I = 1, N
IF( D( I ).EQ.ZERO ) THEN
*
* Avoid -ZERO
*
D( I ) = ZERO
END IF
IF( D( I ).LT.ZERO ) THEN

D( I ) = -D( I )
*
* Change sign of singular vectors, if desired
Expand Down
8 changes: 7 additions & 1 deletion SRC/zbdsqr.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@
*>
*> \param[out] RWORK
*> \verbatim
*> RWORK is DOUBLE PRECISION array, dimension (4*N)
*> RWORK is DOUBLE PRECISION array, dimension (4*(N-1))
*> \endverbatim
*>
*> \param[out] INFO
Expand Down Expand Up @@ -807,6 +807,12 @@ SUBROUTINE ZBDSQR( UPLO, N, NCVT, NRU, NCC, D, E, VT, LDVT, U,
*
160 CONTINUE
DO 170 I = 1, N
IF( D( I ).EQ.ZERO ) THEN
*
* Avoid -ZERO
*
D( I ) = ZERO
END IF
IF( D( I ).LT.ZERO ) THEN
D( I ) = -D( I )
*
Expand Down