Skip to content

Overhaul ValuesJsonConverter #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RehanSaeed merged 19 commits into from
Dec 19, 2019
Merged

Overhaul ValuesJsonConverter #109

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
4589fd0
Initial refactor of ValuesJsonConverter
Turnerj Dec 12, 2019
908d9e6
Remove branch logic for casting to OneOrMany
Turnerj Dec 13, 2019
bb28364
Improve memory allocation for writes
Turnerj Dec 13, 2019
7df50c5
Updating enum string URI logic
Turnerj Dec 13, 2019
3c34f84
Improving hot path for serialization
Turnerj Dec 13, 2019
33ce37f
Use reader directly instead of JToken
Turnerj Dec 13, 2019
f6b24cc
Prevent list allocation for single item
Turnerj Dec 13, 2019
58cc155
Added missing success marker
Turnerj Dec 13, 2019
536a53a
Better support for external types
Turnerj Dec 14, 2019
d4f08f5
Add GUID-from-string support
Turnerj Dec 14, 2019
a3eb4d3
Adds full support for implicit external types in any namespace
Turnerj Dec 16, 2019
2197c96
Add TimeSpan support for reads
Turnerj Dec 17, 2019
b073901
Add support for implicit array conversion
Turnerj Dec 17, 2019
86c4c66
Add write tests for time-related types
Turnerj Dec 17, 2019
1d40a8a
Add support for TimeSpan as ISO 8601 duration
Turnerj Dec 17, 2019
1b0f726
WriteObject to only take individual items
Turnerj Dec 17, 2019
280d05e
TimeSpan converter doesn't need to handle reads
Turnerj Dec 17, 2019
a546cac
Moved model classes to separate folder
Turnerj Dec 17, 2019
6dc7814
Updated test naming to make intention clearer
Turnerj Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add TimeSpan support for reads
  • Loading branch information
@Turnerj
Turnerj committed Dec 17, 2019
commit 2197c963789f666d6aae4582c4deb5ac264984ff
5 changes: 5 additions & 0 deletions Source/Schema.NET/ValuesJsonConverter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,6 +317,11 @@ private static bool TryProcessTokenAsType(JsonReader reader, Type targetType, ou
success = DateTimeOffset.TryParse(valueString, CultureInfo.InvariantCulture, DateTimeStyles.None, out var localResult);
result = localResult;
}
else if (targetType == typeof(TimeSpan))
{
success = TimeSpan.TryParse(valueString, CultureInfo.InvariantCulture, out var localResult);
result = localResult;
}
else if (targetType == typeof(Uri))
Copy link
Owner

@RehanSaeed RehanSaeed Dec 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if Guid should also be here, if we are checking a bunch of types? Not that schema.org has any Guid types (that I know of) but people might want to create custom types with Guids.

Copy link
Collaborator Author

@Turnerj Turnerj Dec 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, GUID might be a good one to add and wouldn't be hard to do.

Copy link
Collaborator Author

@Turnerj Turnerj Dec 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added in d4f08f5 including test.

{
success = Uri.TryCreate(valueString, UriKind.Absolute, out var localResult);
Expand Down
8 changes: 8 additions & 0 deletions Tests/Schema.NET.Test/ValuesJsonConverterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,14 @@ public void ReadJson_Values_SingleValue_DateTimeOffsetAsISO8601String()
Assert.Equal(new DateTimeOffset(2000, 1, 1, 12, 34, 0, TimeSpan.FromHours(1)), result.Value2.First());
}

[Fact]
public void ReadJson_Values_SingleValue_TimeSpanAsISO8601String()
{
var json = "{\"Property\":\"12:34\"}";
var result = this.DeserializeObject<Values<string, TimeSpan>>(json);
Assert.Equal(new TimeSpan(12, 34, 0), result.Value2.First());
}

[Fact]
public void ReadJson_ParseValueToken_UriAsString()
{
Expand Down