Use faster PRNG in the allocations profiler (#57761) #222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rand()` locks and is slow. This uses the seed from `ptls`.
Also remove a warning from array.c
nickrobinson251
approved these changes
Mar 14, 2025
| char *data = (char*)a->data; | ||
| char *newdata; | ||
| char *typetagdata; | ||
| char *typetagdata = NULL; |
There was a problem hiding this comment.
how is this change related?
There was a problem hiding this comment.
It is completely unrelated -- just fixes a warning while building Julia. I can drop it from this PR...?
|
Are we okay to merge this? I don't really think either of my comments need to stop us |
|
Yes, this is merged upstream. |
|
But it would be good to verify that it does help, as your comment suggests. |
|
Evidence of impact: JuliaLang#57761 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
rand()locks and is slow. This uses the seed fromptls.Checklist
Requirements for merging:
port-to-*labels that don't apply.