Skip to content

chore(smart-contracts): publish to tenderly #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexandre-abrioux merged 61 commits into from
Mar 7, 2023
Merged

chore(smart-contracts): publish to tenderly #1048

alexandre-abrioux merged 61 commits into from
Mar 7, 2023

Conversation

@alexandre-abrioux
Copy link
Contributor

@alexandre-abrioux alexandre-abrioux commented Jan 16, 2023 •
edited
Loading

Description of the changes

Adds a command to import contracts in a Tenderly account

Related

@coveralls
Copy link

coveralls commented Jan 31, 2023 •
edited
Loading

Coverage Status

Coverage: 87.599%. Remained the same when pulling 8e4d4cd on tenderly-contracts into 1c240b7 on networks.

alexandre-abrioux
alexandre-abrioux commented Jan 31, 2023
View reviewed changes
@alexandre-abrioux alexandre-abrioux marked this pull request as ready for review January 31, 2023 16:00
benjlevesque
benjlevesque reviewed Jan 31, 2023
View reviewed changes
Copy link
Contributor

@benjlevesque benjlevesque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

A few comments:

  • what will happen on chains not supported by tenderly?
  • could we avoid relying on the (request finance) currency API, in a core library of the protocol? It seems it's used only to get the chainId, which can probably be found with a call to the RPC, that I think is already available in Hardhat configuration?

kevindavee
kevindavee reviewed Jan 31, 2023
View reviewed changes
@alexandre-abrioux alexandre-abrioux changed the base branch from master to networks February 8, 2023 13:53
@alexandre-abrioux
Copy link
Contributor Author

alexandre-abrioux commented Feb 8, 2023

@benjlevesque

  • it looks like Tenderly simply ignores contracts when the chainId is not supported on their side, so all good 👍
  • the dependency from currency-api has been removed thanks to refactor: chain configurations #1056

@alexandre-abrioux alexandre-abrioux mentioned this pull request Feb 16, 2023
Merged
Base automatically changed from networks to master March 7, 2023 13:07
@alexandre-abrioux alexandre-abrioux enabled auto-merge (squash) March 7, 2023 13:15
@alexandre-abrioux alexandre-abrioux merged commit 27aaa1f into master Mar 7, 2023
@alexandre-abrioux alexandre-abrioux deleted the tenderly-contracts branch March 7, 2023 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jerrylaloan jerrylaloan Awaiting requested review from jerrylaloan

@yomarion yomarion Awaiting requested review from yomarion

4 more reviewers

@KolevDarko KolevDarko KolevDarko approved these changes

@benjlevesque benjlevesque benjlevesque approved these changes

@kevindavee kevindavee kevindavee approved these changes

@leoslr leoslr leoslr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alexandre-abrioux @coveralls @KolevDarko @benjlevesque @kevindavee @leoslr