Skip to content

chore: add test - create and declare received payment in a single transaction #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MantisClone merged 3 commits into from
Aug 27, 2024
Merged

chore: add test - create and declare received payment in a single transaction #1443

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62b384b
chore: add test - create and declare received payment at same time
MantisClone Aug 15, 2024
a038cc5
refactor: rename test slightly
MantisClone Aug 15, 2024
766fb35
Merge branch 'master' into create-and-declare-received-at-same-time
MantisClone Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions packages/request-client.js/test/declarative-payments.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,33 @@ describe('request-client.js: declarative payments', () => {
expect(requestData.balance!.balance).toEqual('10');
});

it('allows to create a request and declare a received payment in the same transaction', async () => {
const requestNetwork = new RequestNetwork({
useMockStorage: true,
signatureProvider: TestData.fakeSignatureProvider,
});
const request = await requestNetwork.createRequest({
...requestCreationParams,
requestInfo: {
...TestData.parametersWithoutExtensionsData,
extensionsData: [
{
action: ExtensionTypes.PnAnyDeclarative.ACTION.DECLARE_RECEIVED_PAYMENT,
id: ExtensionTypes.PAYMENT_NETWORK_ID.ANY_DECLARATIVE,
parameters: {
amount: '10',
note: 'received payment',
txhash: '0x0123456789abcdef0123456789abcdef0123456789abcdef0123456789abcdef',
network: 'mainnet',
},
},
],
},
});
const requestData = await request.waitForConfirmation();
expect(requestData.balance!.balance).toEqual('10');
Copy link
Contributor

@coderabbitai coderabbitai bot Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using non-null assertions.

The non-null assertion operator (!) is used on requestData.balance!.balance. It's safer to use optional chaining (?.) to avoid potential runtime errors.

- expect(requestData.balance!.balance).toEqual('10');
+ expect(requestData.balance?.balance).toEqual('10');
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
expect(requestData.balance!.balance).toEqual('10');
expect(requestData.balance?.balance).toEqual('10');
Tools
Biome

[error] 217-217: Forbidden non-null assertion.

Unsafe fix: Replace with optional chain operator ?. This operator includes runtime checks, so it is safer than the compile-only non-null assertion operator

(lint/style/noNonNullAssertion)

});

it('allows to declare a sent refund', async () => {
const requestNetwork = new RequestNetwork({
httpConfig,
Expand Down