-
Notifications
You must be signed in to change notification settings - Fork 91
feat: add Admin scripts for Single Request Proxy Factory #1478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aimensahnoun
merged 5 commits into
master
from
1462-add-admins-scripts-for-the-singlerequestproxyfactory-to-the-sdk
Nov 5, 2024
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a194821
feat: add `SingleRequestProxyFactory` artifacts to getArtifacts method
aimensahnoun 69d7b4c
feat: add task to update the `SingleRequestProxyFactory` fee proxy ad…
aimensahnoun 195297d
Merge branch 'master' of github.com:RequestNetwork/requestNetwork int…
aimensahnoun d354a0a
refactor: refactor admin scripts
aimensahnoun 3beb884
refactor: rename `SRPF` functions
aimensahnoun File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
packages/smart-contracts/scripts-create2/contract-setup/setupSingleRequestProxyFactory.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| import { EvmChains } from '@requestnetwork/currency'; | ||
| import { singleRequestProxyFactoryArtifact } from '../../src/lib'; | ||
| import { HardhatRuntimeEnvironmentExtended } from '../types'; | ||
| import { | ||
| getSignerAndGasFees, | ||
| updateSRPFERC20FeeProxyAddress, | ||
| updateSRPFEthereumFeeProxyAddress, | ||
| } from './adminTasks'; | ||
|
|
||
| /** | ||
| * Setup the SingleRequestProxyFactory values once deployed | ||
| * @param contractAddress address of the SingleRequestProxyFactory contract | ||
| * If not provided fallback to the latest deployment address | ||
| * @param hre Hardhat runtime environment | ||
| * @param signWithEoa Are transactions to be signed by an EOA | ||
| */ | ||
MantisClone marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| export const setupSRPF = async ({ | ||
| contractAddress, | ||
| hre, | ||
| signWithEoa, | ||
| }: { | ||
| contractAddress?: string; | ||
| hre: HardhatRuntimeEnvironmentExtended; | ||
| signWithEoa: boolean; | ||
| }): Promise<void> => { | ||
| await Promise.all( | ||
| hre.config.xdeploy.networks.map(async (network: string) => { | ||
| try { | ||
MantisClone marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| EvmChains.assertChainSupported(network); | ||
| if (!contractAddress) { | ||
| contractAddress = singleRequestProxyFactoryArtifact.getAddress(network); | ||
| } | ||
| if (!contractAddress) { | ||
| console.warn(`Missing SingleRequestProxyFactory deployment on ${network}`); | ||
| return; | ||
| } | ||
MantisClone marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| const factory = new hre.ethers.Contract( | ||
| contractAddress, | ||
| singleRequestProxyFactoryArtifact.getContractAbi(), | ||
| ); | ||
| const { signer, txOverrides } = await getSignerAndGasFees(network, hre); | ||
| const factoryConnected = factory.connect(signer); | ||
MantisClone marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| await updateSRPFERC20FeeProxyAddress( | ||
| factoryConnected, | ||
| network, | ||
| txOverrides, | ||
| signer, | ||
| signWithEoa, | ||
| ); | ||
| await updateSRPFEthereumFeeProxyAddress( | ||
| factoryConnected, | ||
| network, | ||
| txOverrides, | ||
| signer, | ||
| signWithEoa, | ||
| ); | ||
|
|
||
| console.log(`Setup of SingleRequestProxyFactory successful on ${network}`); | ||
| } catch (err) { | ||
| console.warn( | ||
| `An error occurred during the setup of SingleRequestProxyFactory on ${network}`, | ||
| ); | ||
| console.warn(err); | ||
| } | ||
| }), | ||
| ); | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Consider refactoring to reduce code duplication between proxy update functions.
The two functions share almost identical structure and differ only in method names and variable names. Consider refactoring into a single function with a type parameter:
This refactoring:
ProxyTypetype📝 Committable suggestion