-
Notifications
You must be signed in to change notification settings - Fork 91
fix(payment-detection): codegen sepolia URL #1609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe configuration file for code generation in the payment-detection package was updated to use a new GraphQL schema endpoint URL. The previous endpoint was replaced with a new one, while all other configuration settings remained unchanged. Changes
Suggested reviewers
Tip ⚡💬 Agentic Chat (Pro Plan, General Availability)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/payment-detection/codegen.yml (1)
1-2: Consider externalizing the endpoint URL
Hard‑coding the schema URL can make future network migrations or environment-specific overrides cumbersome. You may wish to extract it into an environment variable (e.g.GRAPHQL_SCHEMA_URL) and reference it in this config via Codegen’s env substitution.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/payment-detection/codegen.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build-and-test
🔇 Additional comments (2)
packages/payment-detection/codegen.yml (2)
2-2:Details
✅ Verification successful
Verify removal of stale Studio references
To ensure no legacy Studio URL remains, run a repo‐wide search for the old endpoint and update or remove any hits.
🏁 Script executed:
rg 'studio\\.thegraph\\.com/query/67444/request-payments-sepolia'Length of output: 67
No stale Studio references found
A repo‑wide search for the old Studio endpoint (
studio.thegraph.com/query/67444/request-payments-sepolia) returned no matches, so the legacy URL has been fully removed.
2-2:Details
❌ Incorrect review comment
Switch to Alchemy endpoint for rate‑limit relief
The schema URL has been updated from the Studio endpoint (3 000 req/day limit) to the more reliable Alchemy service for Sepolia. This aligns with the default TheGraphClient configuration and should prevent CI failures due to rate limiting.You can quickly verify connectivity with:
🏁 Script executed:
curl -sI 'https://subgraph.satsuma-prod.com/e2e4905ab7c8/request-network--434873/request-payments-sepolia/api' | head -n 1Length of output: 134
Ignore Alchemy endpoint suggestion
The schema URL is intentionally pointing at Satsuma’s hosted Graph node—not Alchemy—and it’s responding successfully (HTTP/2 200). No changes are required.
- Schema in packages/payment-detection/codegen.yml:
https://subgraph.satsuma-prod.com/e2e4905ab7c8/request-network--434873/request-payments-sepolia/api- Connectivity verified:
HTTP/2 200Likely an incorrect or invalid review comment.
Issue
Subgraph Studio is rate limited to 3k requests/day, which can quickly break the CI when builders use that endpoint too.
Fix
To fix this, we can use the Alchemy URL for code generation, which is also the default in our TheGraphClient.
Summary by CodeRabbit