Skip to content

ci(next-release): fix github ssh key #1653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexandre-abrioux-rf merged 2 commits into from
Nov 7, 2025
Merged

ci(next-release): fix github ssh key #1653

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d8acb8
ci(next-release): fix github ssh key
alexandre-abrioux-rf Nov 5, 2025
cfebd34
fix https://github.com/RequestNetwork/requestNetwork/pull/1653/files#…
alexandre-abrioux-rf Nov 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ jobs:
- *enable_corepack
- run:
name: 'Allow github ssh host'
command: mkdir ~/.ssh; echo 'github.com ssh-rsa AAAAB3NzaC1yc2EAAAABIwAAAQEAq2A7hRGmdnm9tUDbO9IDSwBK6TbQa+PXYPCPy6rbTrTtw7PHkccKrpp0yVhp5HdEIcKr6pLlVDBfOLX9QUsyCOV0wzfjIJNlGEYsdlLJizHhbn2mUjvSAHQqZETYP81eFzLQNnPHt4EVVUh7VfDESU84KezmD5QlWpXLmvU31/yMf+Se8xhHTvKSCZIFImWwoG6mbUoWf9nzpIoaSjB+weqqUUmpaaasXVal72J+UX2B+2RPW3RcT0eOzQgqlJL3RKrTJvdsjE3JEAvGq3lGHSZXy28G3skua2SmVi/w4yCE6gbODqnTWlg7+wC604ydGXA8VJiS5ap43JXiUFFAaQ==' >> ~/.ssh/known_hosts
Copy link
Contributor Author

@alexandre-abrioux-rf alexandre-abrioux-rf Nov 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This public key was deprecated in 2023, see https://github.blog/news-insights/company-news/we-updated-our-rsa-ssh-host-key/

The authorized public keys are listed here: https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/githubs-ssh-key-fingerprints

I'm not sure why the next-release pipeline was still functioning after 2023, even though the key had been deprecated. I suspect that CircleCI was already prefilling the file /home/circleci/.ssh/known_hosts with the proper GitHub keys, so we didn't need to update our workflow. I also suspect that they stopped prefilling the file today following this incident.

command: mkdir -p ~/.ssh && curl -sL https://api.github.com/meta | jq -r '.ssh_keys | .[]' | sed -e 's/^/github.com /' >> ~/.ssh/known_hosts
Copy link
Contributor Author

@alexandre-abrioux-rf alexandre-abrioux-rf Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using a static value, we now get the latest values from GitHub's API

- run:
name: 'Authenticate with registry'
command: echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" > ~/repo/.npmrc
Expand Down