Improve paging #89
Merged
Improve paging #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks! Yeah, let's remove the |
Contributor
|
I created an issue for the configuration documentation: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Gavin, sorry for the wait, I've splitted the commits related to paging to a single pull request. I've also upgraded to the last version of kaminari
There may be one more refactoring (which I haven't done yet). Currently the page_size is set in restpack_serializer config, but since it now uses kaminari's max_per_page, it'd make sense removing the page_size config and instead using kaminari's config (default_per_page) also for this. What do you think?