Skip to content

Fix unwanted query parameter explosion in generated c# client #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
burgmanna wants to merge 2 commits into from
Closed

Fix unwanted query parameter explosion in generated c# client #4310

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9a5b86
Fix unwanted query parameter explosion in generated c# client
ab-translogica Jan 11, 2023
842658f
non exploded query parameters: do not break if more parameters given
ab-translogica Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix unwanted query parameter explosion in generated c# client
  • Loading branch information
@ab-translogica
ab-translogica committed Jan 11, 2023
commit d9a5b86d3a29b0501f54ad6426a385276b3545ca
5 changes: 4 additions & 1 deletion src/NSwag.CodeGeneration.CSharp/Templates/Client.Class.QueryParameter.liquid
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,11 @@ foreach (var item_ in {{ parameter.VariableName }}) { urlBuilder_.Append(System.
urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}") + "=").Append(System.Uri.EscapeDataString({% if parameter.IsNullable and parameter.IsRequired %}{{ parameter.VariableName }} != null ? {% endif %}{{ parameter.VariableName }}{% if parameter.IsSystemNullable %}.Value{% endif %}.ToString("{{ ParameterDateTimeFormat }}", System.Globalization.CultureInfo.InvariantCulture){% if parameter.IsNullable and parameter.IsRequired %} : "{{ QueryNullValue }}"{% endif %})).Append("&");
{% elsif parameter.IsDate -%}
urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}") + "=").Append(System.Uri.EscapeDataString({% if parameter.IsNullable and parameter.IsRequired %}{{ parameter.VariableName }} != null ? {% endif %}{{ parameter.VariableName }}{% if parameter.IsSystemNullable %}.Value{% endif %}.ToString("{{ ParameterDateFormat }}", System.Globalization.CultureInfo.InvariantCulture){% if parameter.IsNullable and parameter.IsRequired %} : "{{ QueryNullValue }}"{% endif %})).Append("&");
{% elsif parameter.IsArray -%}
{% elsif parameter.IsArray and parameter.Explode == true -%}
Copy link

@paulcurren paulcurren Jan 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should also test for "collectionFormat": "csv",

foreach (var item_ in {{ parameter.VariableName }}) { urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}") + "=").Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append("&"); }
{% elsif parameter.IsArray and parameter.Explode == false -%}
urlBuilder_.Append(System.Uri.EscapeDataString("{{ parameter.Name }}") + "=");
foreach (var item_ in {{ parameter.VariableName }}) { urlBuilder_.Append(System.Uri.EscapeDataString(ConvertToString(item_, System.Globalization.CultureInfo.InvariantCulture))).Append(","); }
{% elsif parameter.IsDictionary -%}
foreach (var item_ in {{ parameter.VariableName }}) { urlBuilder_.Append(System.Uri.EscapeDataString(item_.Key) + "=").Append(System.Uri.EscapeDataString(ConvertToString(item_.Value, System.Globalization.CultureInfo.InvariantCulture))).Append("&"); }
{% elsif parameter.IsDeepObject -%}
Expand Down