Skip to content

#5250 - K6 template for Typescript has errors when void is return type #5251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lahma merged 1 commit into from
Aug 15, 2025
Merged

#5250 - K6 template for Typescript has errors when void is return type #5251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions ...hots/K6Tests.When_consumes_is_url_encoded_then_construct_url_encoded_request.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ export class UrlEncodedRequestConsumingClient {
this.commonRequestParameters = commonRequestParameters || {};
}

addMessage(message: Foo | null | undefined, messageId: string | null | undefined, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
addMessage(message: Foo | null | undefined, messageId: string | null | undefined, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -33,16 +33,16 @@ export class UrlEncodedRequestConsumingClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/x-www-form-urlencoded",
},
}
);

return response;
}

/**
*
*/
Expand Down
34 changes: 18 additions & 16 deletions ...shots/K6Tests.When_export_types_is_false_then_dont_add_export_before_classes.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import type { Params, Response } from "k6/http";

interface IDiscussionClient {

addMessage(message: Foo, requestParameters?: Params): void ;
addMessage(message: Foo, requestParameters?: Params): Response;

genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): void ;
genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): Response;

genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): void ;
genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): Response;
}

class DiscussionClient implements IDiscussionClient {
Expand All @@ -22,8 +22,8 @@ class DiscussionClient implements IDiscussionClient {
this.commonRequestParameters = commonRequestParameters || {};
}

addMessage(message: Foo, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
addMessage(message: Foo, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -37,18 +37,19 @@ class DiscussionClient implements IDiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -62,18 +63,19 @@ class DiscussionClient implements IDiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -87,16 +89,16 @@ class DiscussionClient implements IDiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

/**
*
*/
Expand Down
34 changes: 18 additions & 16 deletions ...s/Snapshots/K6Tests.When_export_types_is_true_then_add_export_before_classes.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import type { Params, Response } from "k6/http";

export interface IDiscussionClient {

addMessage(message: Foo, requestParameters?: Params): void ;
addMessage(message: Foo, requestParameters?: Params): Response;

genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): void ;
genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): Response;

genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): void ;
genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): Response;
}

export class DiscussionClient implements IDiscussionClient {
Expand All @@ -22,8 +22,8 @@ export class DiscussionClient implements IDiscussionClient {
this.commonRequestParameters = commonRequestParameters || {};
}

addMessage(message: Foo, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
addMessage(message: Foo, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -37,18 +37,19 @@ export class DiscussionClient implements IDiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -62,18 +63,19 @@ export class DiscussionClient implements IDiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -87,16 +89,16 @@ export class DiscussionClient implements IDiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

/**
*
*/
Expand Down
28 changes: 15 additions & 13 deletions ...NSwag.CodeGeneration.TypeScript.Tests/Snapshots/K6Tests.When_generic_request.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ class DiscussionClient {
this.commonRequestParameters = commonRequestParameters || {};
}

addMessage(message: Foo, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
addMessage(message: Foo, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -28,18 +28,19 @@ class DiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -53,18 +54,19 @@ class DiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -78,16 +80,16 @@ class DiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

/**
*
*/
Expand Down
34 changes: 18 additions & 16 deletions ...ots/K6Tests.When_return_value_is_void_then_client_returns_observable_of_void.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ import type { Params, Response } from "k6/http";

export interface IDiscussionClient {

addMessage(message: Foo, requestParameters?: Params): void ;
addMessage(message: Foo, requestParameters?: Params): Response;

genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): void ;
genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): Response;

genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): void ;
genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): Response;
}

export class DiscussionClient implements IDiscussionClient {
Expand All @@ -22,8 +22,8 @@ export class DiscussionClient implements IDiscussionClient {
this.commonRequestParameters = commonRequestParameters || {};
}

addMessage(message: Foo, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
addMessage(message: Foo, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -37,18 +37,19 @@ export class DiscussionClient implements IDiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
genericRequestTest1(request: GenericRequest1 | null | undefined, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -62,18 +63,19 @@ export class DiscussionClient implements IDiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): void {
const _mergedRequestParameters = this._mergeRequestParameters(
genericRequestTest2(request: GenericRequest2 | null | undefined, requestParameters?: Params): Response {
const mergedRequestParameters = this._mergeRequestParameters(
requestParameters || {},
this.commonRequestParameters,
);
Expand All @@ -87,16 +89,16 @@ export class DiscussionClient implements IDiscussionClient {
url_.toString(),
content_,
{
..._mergedRequestParameters,
...mergedRequestParameters,
headers: {
..._mergedRequestParameters?.headers,
...mergedRequestParameters?.headers,
"Content-Type": "application/json",
},
}
);

return response;
}

/**
*
*/
Expand Down
Loading
Loading