fix: display correct artist album track listing#130
Merged
Conversation
Contributor
Author
|
Whoops, not sure what to do about the failing test here... I still don't quite have the context of the full app to fully understand what is being tested or if it would be safe to remove the test. Do I need to update it? Bringing in Any advice here would be appreciated. Thanks! |
Rigellute
approved these changes
Nov 4, 2019
Owner
Rigellute
left a comment
There was a problem hiding this comment.
Great stuff, thanks for figuring this out and fixing.
The origin of the failing test is that the deleted import ActiveBlock is used in the test.
To fix, add this line down in the test
#[cfg(test)]
mod tests {
use super::*;
+ use crate::app::ActiveBlock;
nighi
pushed a commit
to nighi/spotify-tui
that referenced
this pull request
Jul 11, 2025
fix: display correct artist album track listing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #106