Skip to content

fix: display correct artist album track listing#130

Merged
Rigellute merged 3 commits into
Rigellute:masterfrom
sputnick1124:106-wrong-album
Nov 4, 2019
Merged

fix: display correct artist album track listing#130
Rigellute merged 3 commits into
Rigellute:masterfrom
sputnick1124:106-wrong-album

Conversation

@sputnick1124
Copy link
Copy Markdown
Contributor

Addresses #106

@sputnick1124
Copy link
Copy Markdown
Contributor Author

Whoops, not sure what to do about the failing test here... I still don't quite have the context of the full app to fully understand what is being tested or if it would be safe to remove the test. Do I need to update it? Bringing in ActiveBlock just for the test would of course help the test along, but seems not to be the most sensible approach?

Any advice here would be appreciated. Thanks!

Copy link
Copy Markdown
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff, thanks for figuring this out and fixing.

The origin of the failing test is that the deleted import ActiveBlock is used in the test.

To fix, add this line down in the test

#[cfg(test)]
mod tests {
    use super::*;
+   use crate::app::ActiveBlock;

@Rigellute Rigellute merged commit 923a603 into Rigellute:master Nov 4, 2019
nighi pushed a commit to nighi/spotify-tui that referenced this pull request Jul 11, 2025
fix: display correct artist album track listing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants