Added pagnation to user playlists#150
Merged
Merged
Conversation
Rigellute
requested changes
Nov 18, 2019
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
Thanks for looking into this.
Unfortunately, I've made a bit of a mess with regards to implementing pagination, which needs to be fixed.
But this looks fine for now.
Only thing to fix is the hardcoded offset
Contributor
Author
|
I spotted a problem with the navigation when paging so I added a check to see if the new table should be added to the navigation stack. |
Rigellute
approved these changes
Nov 18, 2019
Owner
|
Thanks for again for the contribution |
Closed
Owner
|
@all-contributors please add @Peterkmoss for code |
Contributor
|
I've put up a pull request to add @Peterkmoss! 🎉 |
nighi
pushed a commit
to nighi/spotify-tui
that referenced
this pull request
Jul 11, 2025
Added pagnation to user playlists
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added some simple pagnation to at least scroll through your playlist. I don't know if this is the best way to implement it but it seems to work fine from my own testing. Please excuse if my Rust is "rusty", it's my first Rust project and I don't know if there is need for memory optimization for this change to not leak memory.