Go back does not work in Liked Songs#151
Merged
Conversation
Rigellute
approved these changes
Nov 18, 2019
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
Ah yes, makes sense - scrolling was pushing to the stack!
Rigellute
requested changes
Nov 18, 2019
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
Are you able to clean up the commits? Given this small change, I feel this should be one commit. The many commits could be because of a merge rather than a rebase?
Author
|
As you said, i merged branches to master and they contaminated it. I cleaned up unnecessary commits. |
Rigellute
approved these changes
Nov 18, 2019
ghost
deleted the
nighi
pushed a commit
to nighi/spotify-tui
that referenced
this pull request
Jul 11, 2025
…able Go back does not work in Liked Songs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Go back
qdoes not work as expected after scrolling pages in Liked Songs.When i scrolled pages in Liked Songs and pushed
q, i expected that the Library block is activated but nothing occurred.This problem caused by calling push_navigation_stack in get_current_user_saved_tracks.
I tried to fix this problem by removing push_navigation_stack from get_current_user_saved_tracks and pushing to the stack is called first time.