Adjust volume controls behaviour#166
Merged
Merged
Conversation
gpawlik
force-pushed
the
volume-adjust
branch
from
340cc5a to
06c0ed5
Compare
Rigellute
approved these changes
Nov 26, 2019
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
Ah yes, makes sense! Since we are manually updating the volume percent on success, the additional call for current playback is unnecessary, and causes the app to block while we wait for the request to resolve.
The app is currently single threaded with no async runtime. This is something I'm trying to find the time to work on improving!
Thanks for investigating and solving this issue!
Also, great PR description 👍
Owner
|
This PR will close #101 |
nighi
pushed a commit
to nighi/spotify-tui
that referenced
this pull request
Jul 11, 2025
Adjust volume controls behaviour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
The volume control does not work as intended, if
+and-are pressed in a moderate pace the value updates every second press, and after some time it starts to get even more messy.Solution to the issue
I have removed
get_current_playbackcall after the successful volume change. In this context I think it is not necessary to poll for the playback data, but maybe I am missing something, would you be able to confirm it @Rigellute ?Before/After screenshots 📷