Skip to content

Adjust min/max volume values#170

Merged
Rigellute merged 1 commit into
Rigellute:masterfrom
gpawlik:clamp-volume
Nov 27, 2019
Merged

Adjust min/max volume values#170
Rigellute merged 1 commit into
Rigellute:masterfrom
gpawlik:clamp-volume

Conversation

@gpawlik
Copy link
Copy Markdown
Contributor

@gpawlik gpawlik commented Nov 26, 2019

Description of the issue

Currently if the initial volume is not of full tens (eg. 42) then the min and max values are respectively 2 and 92.

Solution to the issue

Limit the volume values correctly on 0 and 100.

Before/After screenshots 📷

Before After
v2 v1

Copy link
Copy Markdown
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @gpawlik! I wondered about this problem myself so thank you for fixing it!

@Rigellute Rigellute merged commit 2badc3e into Rigellute:master Nov 27, 2019
@gpawlik
Copy link
Copy Markdown
Contributor Author

gpawlik commented Nov 27, 2019

It's a pleasure! 😄

@Rigellute
Copy link
Copy Markdown
Owner

@all-contributors please add @gpawlik for code

@allcontributors
Copy link
Copy Markdown
Contributor

@Rigellute

I've put up a pull request to add @gpawlik! 🎉

nighi pushed a commit to nighi/spotify-tui that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants