Skip to content

Add play recommendations for song/artist on pressing 'r'#200

Merged
Rigellute merged 5 commits into
Rigellute:masterfrom
neriglissar:play-recommendations-for-selected-seed
Jan 26, 2020
Merged

Add play recommendations for song/artist on pressing 'r'#200
Rigellute merged 5 commits into
Rigellute:masterfrom
neriglissar:play-recommendations-for-selected-seed

Conversation

@neriglissar
Copy link
Copy Markdown
Contributor

@neriglissar neriglissar commented Jan 4, 2020

I implemented a feature which on keypress 'r' loads a list of recommended songs for the selected song or artist and starts playback. This functionality was requested in issue #171 (see also #129).

Screenshot 2020-01-04 at 09 21 39

@neriglissar neriglissar requested a review from Rigellute January 17, 2020 15:14
@Rigellute
Copy link
Copy Markdown
Owner

@neriglissar sorry for the delay in reviewing this. Currently about half way through.

This looks like an awesome feature!

Copy link
Copy Markdown
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 👏 , just have one requested change regarding the pagination limit. Once fixed, it's good to go 👍

Comment thread src/app.rs Outdated
Copy link
Copy Markdown
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great work @neriglissar! Thank you for your contribution.

@Rigellute Rigellute merged commit 28e01ae into Rigellute:master Jan 26, 2020
@Rigellute
Copy link
Copy Markdown
Owner

@all-contributors please add @neriglissar for code

@allcontributors
Copy link
Copy Markdown
Contributor

@Rigellute

I've put up a pull request to add @neriglissar! 🎉

@Rigellute
Copy link
Copy Markdown
Owner

@all-contributors please add @neriglissar for code

@allcontributors
Copy link
Copy Markdown
Contributor

@Rigellute

I've put up a pull request to add @neriglissar! 🎉

nighi pushed a commit to nighi/spotify-tui that referenced this pull request Jul 11, 2025
…s-for-selected-seed

Add play recommendations for song/artist on pressing 'r'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants