Skip to content

Play every known song with e#228

Merged
Rigellute merged 3 commits into
Rigellute:masterfrom
AlexandreSi:play-every-known-song
Jan 30, 2020
Merged

Play every known song with e#228
Rigellute merged 3 commits into
Rigellute:masterfrom
AlexandreSi:play-every-known-song

Conversation

@AlexandreSi
Copy link
Copy Markdown
Contributor

Hi there,

My first PR to address #213.

I added the ability to play every song for an artist from artists, I think it corresponds to the Artists tab from Library. I did it according to @Rigellute indications.

I am not sure if it should be implemented in another place.

Don't hesitate if you have any comments!

Copy link
Copy Markdown
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work @AlexandreSi 👏

Just one comment to change the "help" text for this key binding.

Comment thread src/ui/help.rs Outdated
Co-Authored-By: Alexander Keliris <rigellute@gmail.com>
@NeverI
Copy link
Copy Markdown

NeverI commented Jan 29, 2020

Awesome, thank you very much!

Copy link
Copy Markdown
Owner

@Rigellute Rigellute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AlexandreSi 🙏

@all-contributors please add @AlexandreSi for code

@Rigellute Rigellute merged commit 5ab7c16 into Rigellute:master Jan 30, 2020
@AlexandreSi AlexandreSi deleted the play-every-known-song branch February 2, 2020 12:07
nighi pushed a commit to nighi/spotify-tui that referenced this pull request Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants