Add more readline shortcuts and make ^U work like readline#425
Merged
Conversation
Rigellute
reviewed
May 1, 2020
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
This looks like a nice addition - only got one request to change to something other than using Ctrl('c') since this is the global exit key for the app.
Contributor
Author
|
Maybe Ctrl-L (Clear screen in readline) ? |
Owner
|
|
Previously, it would delete the whole line. Now it deletes only the part of the line before the cursor and Ctrl-L deletes the whole line.
Contributor
Author
|
I just changed it, should be OK now! |
Rigellute
reviewed
May 4, 2020
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
Great work @fratajczak, I just checked out your branch and it's looking good!
I have one more request, would you mind adding these new bindings to the help menu? (src/ui/help.rs around line 67)
Thanks for your work
Rigellute
approved these changes
May 4, 2020
Owner
|
@all-contributors please add @fratajczak for code |
Contributor
|
I've put up a pull request to add @fratajczak! 🎉 |
nighi
pushed a commit
to nighi/spotify-tui
that referenced
this pull request
Jul 11, 2025
Add more readline shortcuts and make ^U work like readline
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.