Add 'enable_text_emphasis' behavior config option#573
Merged
Conversation
Rigellute
approved these changes
Sep 22, 2020
| let modifier = if app.user_config.behavior.enable_text_emphasis { | ||
| Modifier::ITALIC | Modifier::BOLD | ||
| } else { | ||
| Modifier::empty() |
Owner
|
@all-contributors please add @kepae for code and doc |
Contributor
|
I've put up a pull request to add @kepae! 🎉 |
Closed
lanej
pushed a commit
to lanej/spotify-tui
that referenced
this pull request
Jul 13, 2021
nighi
pushed a commit
to nighi/spotify-tui
that referenced
this pull request
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in Issue #568, some users' terminals can have escaping issues with text emphasis.
This pull request introduces a new field named
enable_text_emphasistoBehaviorConfig.BehaviorConfigseemed better suited as a home for this bit thanTheme, and required less work. ;-)Open to simpler/more sustainable ways to make this change, of course! First time contributer here.