Full Podcast support#581
Merged
Merged
Conversation
Still populating each item with some dummy values and don't currently update the selected show index, but navigation seems to work mostly correctly.
Still need to clean a number of things up in the display
Changed: * Display "Date - Title - Duration" for episodes instead of full description (it was too wordy/messy for most podcasts) * Properly mark the currently playing episode
This commit will force a re-auth of the app since it requires the `user-read-playback-position` scope. Changes: * Display <curr progess> / <duration> in the Duration column for episodes * Display ✔ next to episodes that have been fully played
There is currently no such thing as a context for playing episodes, and the only collection of episodes that is possible is the episodes from a show, so there's not currently a need to handle the playing or navigation context of the episode table. If there is some time in the future when it makes sense, it can be implemented then.
sputnick1124
force-pushed
the
podcast-support-search
branch
from
3a0110d to
f807708
Compare
sputnick1124
force-pushed
the
podcast-support-search
branch
from
f807708 to
57249c1
Compare
Owner
|
Wow! Amazing work @sputnick1124 - I will get to reviewing this as soon as I can. |
added 4 commits
September 22, 2020 09:01
…124/spotify-tui into podcast-support-search
Contributor
Author
|
Awesome! I wasn't sure where to put the search results without cluttering up the page, while also making them easy to get to, so if the layout seems bad to people, we can figure out a better way. I think tui-rs has tab support, so we could leverage that perhaps. I'm open to any changes that we think should be made to either the UI or implementation. |
Open
Rigellute
reviewed
Sep 30, 2020
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
Really impressive work @sputnick1124, this looks great.
I've just got one question about unfamiliar syntax, but we should be good to go.
added 2 commits
September 30, 2020 13:19
Owner
|
👏 |
Owner
|
@all-contributors please add @sputnick1124 for code, bug, maintenance, question, doc |
Contributor
|
I've put up a pull request to add @sputnick1124! 🎉 |
lanej
pushed a commit
to lanej/spotify-tui
that referenced
this pull request
Jul 13, 2021
* Handle ctrl-h like backspace * Stub out podcast search results * Draw podcast search results * Draw rough podcast episode table Still populating each item with some dummy values and don't currently update the selected show index, but navigation seems to work mostly correctly. * Stub out EpisodeTable handlers * Get episode playback working. Still need to clean a number of things up in the display * Rename MyShows -> SavedShows * Make borrow checker happy * RustFmt fixes * Better Date/Title/Duration layout Changed: * Display "Date - Title - Duration" for episodes instead of full description (it was too wordy/messy for most podcasts) * Properly mark the currently playing episode * Show episode resume point/played status This commit will force a re-auth of the app since it requires the `user-read-playback-position` scope. Changes: * Display <curr progess> / <duration> in the Duration column for episodes * Display ✔ next to episodes that have been fully played * rustfmt appeasement * Get rid of EpisodeTableContext There is currently no such thing as a context for playing episodes, and the only collection of episodes that is possible is the episodes from a show, so there's not currently a need to handle the playing or navigation context of the episode table. If there is some time in the future when it makes sense, it can be implemented then. * Add jump_to[start|end] for show episodes * Remove debug print * Update to match new tui API * Make rustfmt happy * Toggle order of podcast episodes * Handle ShowSearch for new key option * Use user config'd keys for paging Co-authored-by: Nicklas Stockton <nicklas.stockton@ngc.com>
nighi
pushed a commit
to nighi/spotify-tui
that referenced
this pull request
Jul 11, 2025
* Handle ctrl-h like backspace * Stub out podcast search results * Draw podcast search results * Draw rough podcast episode table Still populating each item with some dummy values and don't currently update the selected show index, but navigation seems to work mostly correctly. * Stub out EpisodeTable handlers * Get episode playback working. Still need to clean a number of things up in the display * Rename MyShows -> SavedShows * Make borrow checker happy * RustFmt fixes * Better Date/Title/Duration layout Changed: * Display "Date - Title - Duration" for episodes instead of full description (it was too wordy/messy for most podcasts) * Properly mark the currently playing episode * Show episode resume point/played status This commit will force a re-auth of the app since it requires the `user-read-playback-position` scope. Changes: * Display <curr progess> / <duration> in the Duration column for episodes * Display ✔ next to episodes that have been fully played * rustfmt appeasement * Get rid of EpisodeTableContext There is currently no such thing as a context for playing episodes, and the only collection of episodes that is possible is the episodes from a show, so there's not currently a need to handle the playing or navigation context of the episode table. If there is some time in the future when it makes sense, it can be implemented then. * Add jump_to[start|end] for show episodes * Remove debug print * Update to match new tui API * Make rustfmt happy * Toggle order of podcast episodes * Handle ShowSearch for new key option * Use user config'd keys for paging Co-authored-by: Nicklas Stockton <nicklas.stockton@ngc.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fully functional as is, but still missing some features that I think should be implemented before this is considered complete. Here's the status on this thus far. Open to cutting this PR here and opening new PRs for remaining tasks. Otherwise, I plan on getting rid of the draft status when the following are complete:
Library podcast viewDisplay episode description with new hotkey (CTRL-]?)*
Paged episode results/ filter by FullyPlayed statusFollow/Unfollow podcasts (from episode table, show search view, and playbar context)UPDATE: This PR is getting to be pretty big already. I think the other features can be implemented piecemeal in smaller PRs to follow. Some of these are fairly simple and could be good opportunities for newcomers to get their feet wet in the project.
Note that the above GIF shows the progress bar from #563