Handle invalid Client ID/Secret#668
Merged
Merged
Conversation
Rigellute
approved these changes
Jan 27, 2021
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
So sorry for the extremely late review. This looks great! Thank you 👍
Owner
|
@all-contributors please add @aokellermann for code |
Contributor
|
I've put up a pull request to add @aokellermann! 🎉 |
lanej
pushed a commit
to lanej/spotify-tui
that referenced
this pull request
Jul 13, 2021
* Implemented client id/secret validation * Abstract out common function * Fix * Implemented error * Address clippy
nighi
pushed a commit
to nighi/spotify-tui
that referenced
this pull request
Jul 11, 2025
* Implemented client id/secret validation * Abstract out common function * Fix * Implemented error * Address clippy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This makes it such that the config file is not written unless valid inputs are entered, so the user will not have to manually edit or delete the config file.