Replace black and white default colors with reset.#742
Merged
Conversation
Rigellute
reviewed
Feb 27, 2021
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
Thanks for looking at this. Just one problem I can see. Not sure if there's a general solution for dark/light colour schemes?
Previously, text would be white, which is not visible on bright color schemes. The color for non-highlighted text now uses the default foreground color of the users terminal emulator, making it visible in any theme. The only visual change in dark color schemes is that the playbar text might go from black to white, depending on the users terminal emulator (some terminal emulators swap fore- and background colors on a colored background depending on the background color; this is IMO the correct behavior anyway).
Jesse-Bakker
force-pushed
the
default_colors
branch
from
e8dfb5f to
a49984d
Compare
Rigellute
approved these changes
Feb 27, 2021
Owner
Rigellute
left a comment
Rigellute
left a comment
There was a problem hiding this comment.
Good work @Jesse-Bakker, thank you
Owner
|
@all-contributors please add @Jesse-Bakker for code |
Contributor
|
I've put up a pull request to add @Jesse-Bakker! 🎉 |
lanej
pushed a commit
to lanej/spotify-tui
that referenced
this pull request
Jul 13, 2021
Previously, text would be white, which is not visible on bright color schemes. The color for non-highlighted text now uses the default foreground color of the users terminal emulator, making it visible in any theme. The only visual change in dark color schemes is that the playbar text might go from black to white, depending on the users terminal emulator (some terminal emulators swap fore- and background colors on a colored background depending on the background color; this is IMO the correct behavior anyway).
nighi
pushed a commit
to nighi/spotify-tui
that referenced
this pull request
Jul 11, 2025
Previously, text would be white, which is not visible on bright color schemes. The color for non-highlighted text now uses the default foreground color of the users terminal emulator, making it visible in any theme. The only visual change in dark color schemes is that the playbar text might go from black to white, depending on the users terminal emulator (some terminal emulators swap fore- and background colors on a colored background depending on the background color; this is IMO the correct behavior anyway).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, text would be white, which is not visible on bright color
schemes. The color for non-highlighted text now uses the default
foreground color of the users terminal emulator, making it visible in
any theme. The only visual change in dark color schemes is that the
playbar text might go from black to white, depending on the users
terminal emulator (some terminal emulators swap fore- and background
colors on a colored background depending on the background color; this
is IMO the correct behavior anyway).