Skip to content

Conversation

@AlexanderDzhoganov
Copy link
Collaborator

I have done some clean-up on the database parser. Haven't integrated my changes with the already existing code in parser.js as I haven't read up on the Dissolve library. Maybe somebody would be willing to further improve on this, but I think it works OK for now.

@rgbkrk
Copy link
Member

rgbkrk commented Nov 24, 2015

Maybe somebody would be willing to further improve on this, but I think it works OK for now.

We can go with this and iterate.

I'd rather not use buffertools though because of it being a native extension, though I can't tell which functionality you're using from first glance.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing a capital N here in JSON.parse

@rgbkrk
Copy link
Member

rgbkrk commented Nov 24, 2015

I'm going to merge this and address a few things in a follow up.

Also adding you as a maintainer.

rgbkrk added a commit that referenced this pull request Nov 24, 2015
Packet decoder + DB parser (moved from pipboyrelay/#5)
@rgbkrk rgbkrk merged commit f15b3ff into RobCoIndustries:master Nov 24, 2015
@AlexanderDzhoganov
Copy link
Collaborator Author

Thanks for adding me as a maintainer. I have addressed the buffertools issue in this PR.

@rgbkrk rgbkrk mentioned this pull request Nov 24, 2015
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just noticed this is defined here but not used. Should we verify that size still === this.expectedSize?

@rgbkrk
Copy link
Member

rgbkrk commented Nov 24, 2015

In case anyone is wondering I favor a model of Optimistic Merging and of shared maintenance. If you contribute, you have a share. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants