Skip to content

Conversation

@kitten
Copy link
Contributor

@kitten kitten commented Nov 25, 2015

No description provided.

@rgbkrk
Copy link
Member

rgbkrk commented Nov 25, 2015

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these all the identity function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what you mean by identity functions? I just replaced the functions with arrow functions and split the names from them

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f(x) returning x

@rgbkrk
Copy link
Member

rgbkrk commented Nov 25, 2015

Looking good. Since I know from gitter you want to do follow up to this and only one interface that I can tell has changed (UDPRelay.listen), let's merge this and keep going.

@kitten
Copy link
Contributor Author

kitten commented Nov 25, 2015

@rgbkrk I also added the relays to the index.js exports btw

@rgbkrk
Copy link
Member

rgbkrk commented Nov 25, 2015

Cool cool. We'll adapt that in pipboyrelay.

Thanks again for doing this. I always hate reviewing refactor dialect PRs, though I'm really thankful after its done.

rgbkrk added a commit that referenced this pull request Nov 25, 2015
Refactor project to use Babel and ES6
@rgbkrk rgbkrk merged commit 8c45790 into RobCoIndustries:master Nov 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants