run the build on prepublish #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For users of the library, this makes it so they don't have to build our released copy. For developers of the library, `npm install` on a dev copy will run prepublish (noted `npm` behavior).
Contributor
|
We need to revert this. What if someone installs this via git? It is just unclean to publish the package including the lib folder. The build process runs automatically so it shouldn't bother anyone. We could even make it more silent. |
Member
Author
|
The pattern I've been used to is that we publish, directly, Totally fine to revert and I understand the install from git case. I presume it didn't run that extra step for you then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users of the library, this makes it so they don't have to build
our released copy on install straight from npm.
For developers of the library,
npm installon a dev copy will runprepublish (noted
npmbehavior).