Skip to content

fix: add validation for SAML SLO redirect URLs #38994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
julio-rocketchat merged 9 commits into from
Mar 26, 2026
Merged

fix: add validation for SAML SLO redirect URLs #38994

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f574d8c
fix: add validation for SAML SLO redirect URLs
yasnagat Feb 24, 2026
fd4998d
Normalize path comparison for redirect validation
yasnagat Feb 27, 2026
8411cf9
Merge branch 'develop' into saml-redirect-validation
yasnagat Feb 27, 2026
6843866
Update apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
yasnagat Mar 3, 2026
568e6c3
add changeset file
yasnagat Mar 4, 2026
0e154f3
Merge branch 'develop' into saml-redirect-validation
julio-rocketchat Mar 17, 2026
3346067
Update apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
julio-rocketchat Mar 19, 2026
7dd041a
Merge branch 'develop' into saml-redirect-validation
julio-rocketchat Mar 19, 2026
6b923a5
Merge branch 'develop' into saml-redirect-validation
yasnagat Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts 
Co-authored-by: Pierre Lehnen <55164754+pierre-lehnen-rc@users.noreply.github.com>
  • Loading branch information
@yasnagat @pierre-lehnen-rc
yasnagat and pierre-lehnen-rc authored Mar 3, 2026
commit 68438669e3f9722eaac99a14f969b3c616928f8e
2 changes: 1 addition & 1 deletion apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ export class SAML {
return;
}

if (!userRedirect) {
if (!userRedirect || typeof userRedirect !== 'string') {
res.writeHead(400);
res.end('Missing redirect parameter');
return;
Expand Down
Loading